Select inventory backpack to move

[runegolemsentry]

I am farming a boss of an instance to get his drops.
When the inventory is full, i want the bot to open the rented bank and move the items inside the bag6 to the bank.
This is what i tryed to do:

Code: Select all

   
function BankMove()
      if inventory:itemTotalCount(0) == 0 then
         sendMacro("OpenBank()"); yrest(2000);
         item = IDUNNOWHATTUPUTHERE
         item:moveTo("bank");
         end
      end
 end

How can i make the "item" to move be a selected backpack?

[lisa]

Code: Select all

function BankMove()
      if inventory:itemTotalCount(0) == 0 then
         sendMacro("OpenBank()"); yrest(2000);
         for slot = 211,240,1 do --bag 6, i think
              item = inventory.BagSlot[slot]
              item:moveTo("bank");
         end
      end
 end

[runegolemsentry]

Code: Select all

function BankMove()
      if inventory:itemTotalCount(0) == 0 then
         sendMacro("OpenBank()"); yrest(2000);
         for slot = 211,240,1 do --bag 6, i think
              item = inventory.BagSlot[slot]
              item:moveTo("bank");
         end
      end
 end

can i ask what is the "1" after 211,240 for?
By the way just tryed, but something goes wrong.

EDIT: when moving, it moves only one item out of 2. for example placing 18 items (the first 3 lines), 9 are moved and 9 rest there. it picks an item, swaps his place with the next one and moves this to the bank, but the first item rests in the bag

[lisa]

the 1 is to make sure it does it in increments of 1, so 211 212 213 214 215, default is usually 1 but when I use a range not starting with 1 I usually add it in just to make sure.
So if it was 1,25 I wouldn't bother with adding the increment value.

Sorry but I don't understand what you said it is doing, chances are it will just need an inventory:update() added in to make sure it isn't moving items to a spot you already moved an item to.

Code: Select all

function BankMove()
      if inventory:itemTotalCount(0) == 0 then
         sendMacro("OpenBank()"); yrest(2000);
         for slot = 211,240,1 do --bag 6, i think
              inventory:update()
              item = inventory.BagSlot[slot]
              item:moveTo("bank");
              yrest(200)
         end
      end
 end

added in a little rest aswell.

[runegolemsentry]

You perfectly answered to my question, even if you didn't understand it
One more thing, the inventory:update works, but no totally. just did a try placing 20 items to move, the first 8 were moved to bank without troubles, but for the other 12 i had again the same problem, bot moving items in bank slots which it moved items already. maybe a "repeat" command on the inventory:update() ?

[lisa]

I added in a rest to the code, try that.

[runegolemsentry]

i made it look like that

Code: Select all

inventory:update();
bank:update();

and now it works perfectly even with full bag. i don't know exactly if ";" is a sort of a rest, i'm kinda new in all this still, but this or the bank:update() made it work

[lisa]

it would be the bank update, the ; is just to say that is the end of that bit of code, it is obsolete now though as of like LUA 5.1 (I think).
So having it there does nothing.


I suspect the updates are just making it do that little bit of extra work which is like having a rest, if you tried it without the updates and just the rest it will probably still work.

[rock5]

Moving is supposed to work better than that now. I just had a look. Looks like there is a line missing from the bank:findItem function that exists in the inventory:findItem and guildbank:findItem functions. This line is supposed to stop it from using empty slots more than once in a row. I don't know why it's missing. It can't possibly have worked as well as I remember with that line missing.

Anyway I added that line and it works as expected. The fix you came up with might work but I suspect it would be a lot, lot slower in comparison. Here is that bank class with that 1 line added.

bank.lua

(1.6 KiB) Downloaded 184 times

With this version you wont need to do the updates or include the yrest and it should be very fast.

[Cindy]

Code: Select all

	--	Phirius Potion - Type D
	while inventory:itemTotalCount("Phirius Potion - Type D") > 0 do
		local x = inventory:findItem("Phirius Potion - Type D")
        if x then x:moveTo("bank")  printf("Bank deposit : "..x.Name); yrest(789); end
	end	

This doesn't work if I already have some in the bank, the one in the bank briefly turns grey, but the others do not get stacked on it. Is there any way to stack them in the bank?

[rock5]

Try the 'bank.lua' file I posted in my previous post.

[Cindy]

Another thing I just found:

While trying to move itemshop items from the backpack to the itemshop backpack, when I had some of the items in the itemshop already it wouldn't move those in the backpack (even though there were empty spaces, though I'd prefer it stacked). As soon as I moved the items from the itemshop pack to the main backpack, the exact same command executed successfully (ie. moved the now one stack items to the itemshop).

Whatever fix you did to bank.lua may need to be made somewhere else too?

[rock5]

I'll have a look but the itemshop backpack is part of the inventory class along with the regular bags.

[rock5]

I just tested it. I took 1 of every stack of items in my itemshop bag and put them in my normal bags. That was 10 separate items. Then I just did

Code: Select all

for i = 61,70 do inventory.BagSlot[i]:moveTo("itemshop") end

and they all got moved to their respective stacks. So I'm not sure what you're doing wrong. I even took 30 from one big stack and split them into single items and filled my first bag. It stacked them all onto 1 stack in my itemshop bag, although it failed about 1 in 15 which is not bad. It only failed because it was stacking multiple items onto the same stack. 30 different types of items wouldn't have had that issue.

[Cindy]

Ok ill run some more to see what happened. Thanks for checking rock.