Patch 4.0.10.2519

[_hirondelle]

But with speedhack, the first five minutes were ok but 30 sec later, I died 2 times.

So it worked for 5 minutes? It either works or it doesn't. If it worked then you died after 5 minutes then the problem is something else or an existing issue with speedhack, such as going too fast.

Nothing bad happens the first five minutes, after I died.
I was running to fast yep

[jasn]

Looks like pet.lua went backwards.

It used to be

Code: Select all

	-- Check if already have the buff
	local HavePetBuff = player:getBuff("503946,503581,503580")
	if buffname == GetIdName(HavePetBuff) then
		return
	end

Then I changed it to

Code: Select all

	-- Check if already have the buff
	if player:getBuff(buffname) then
		return
	end

But it seems it is now back to the old code, not sure when it happened.

line 103 of rom/classes/pet.lua

Just edit the file and see how it goes, I can't do any testing at the moment so I'm not going to commit it.

Thanks Lisa, works like a charm again, i had it running for 20 mins so it rebuffs and resummons just to check those parts.

[rock5]

The code is

Code: Select all

	-- Check if already have the buff
	local HavePetBuff = player:getBuff("503946,503581,503580")
	if buffname == GetIdName(HavePetBuff) then
		return
	end

I can only find it written one other way

Code: Select all

	-- Check if already have the buff
	local HavePetBuff = player:getBuff("503946,503581,503580")
	if buffid == HavePetBuff then
		return
	end

By the looks of it, neither of these will work. player.getBuff returns a table, not a string name or Id number. So it should be

Code: Select all

	if buffid == HavePetBuff.Id then

or with the way it is cuurently written

Code: Select all

	if buffname == HavePetBuff.Name then

[rock5]

On second thought you would also have to check if there is a match before comparing the name. So I think it should be

Code: Select all

	if HavePetBuff and buffname == HavePetBuff.Name then

[lisa]

Wouldn't the code I posted work??
Since buffname is already decided in earlier code

Code: Select all

	if type(_nameorid) == "number" then
		buffname = GetIdName(_nameorid)
	else
		if string.find(string.lower(_nameorid), "spirit" ) or
			string.find(string.lower(_nameorid), "heart" ) then
			buffname = GetIdName(503946)
		elseif string.find(string.lower(_nameorid), "nature") then
			buffname = GetIdName(503581)
		elseif string.find(string.lower(_nameorid), "walker") then
			buffname = GetIdName(503580)
		else
			error("Unrecognized name for warden pet buff.")
		end
	end

Code: Select all

	-- Check if already have the buff
	if player:getBuff(buffname) then
		return
	end

So you only have to look for the buff you want, which the code I posted does.

[rock5]

Wouldn't the code I posted work??

Umm... Yes.

I thought you meant you had previously committed it but then it was reverted. Now I'm understanding you meant you had changed it but never committed it and lost the changes?

Anyway, that's the right way to do it.

I'm a bit confused by the "name" side of it. I understand the "spirit", "heart" etc are only code words? If so why do a string.find?

You could do an actual string comparison like this or something like it.

Code: Select all

elseif string.find(GetIdName(493347),_nameorid) then -- power of the oak
    buffname = GetIdName(503580)

[lisa]

I thought you meant you had previously committed it but then it was reverted.

I thought I had commited it, not going to bother checking as it doesn't really matter lol

I'm a bit confused by the "name" side of it. I understand the "spirit", "heart" etc are only code words? If so why do a string.find?

The default bot uses the buff ID's and so that code is purely there incase anyone wants to add in their own usage of warden pet buffs, So they could do.

Code: Select all

wardenbuff("spirit")
or
wardenbuff("spirit buff me baby")

At some stage in their WP or what ever, it basically just added versatility into warden pet buff instead of purely working for default bot with ID's