skills.xml - question on knight skill

[Rickster]

in skills.xml there is the knight skill

Code: Select all

<skill name="KNIGHT_SHOCK" id="490158" mana="25" cooldown="30" range="150" type="damage" target="enemy" reqbuffname="500137" reqbufftarget="target" reqbuffcount="1" />

using this skill in a profile does not work for me.
i do not know what these skill options do:

Code: Select all

reqbuffname="500137" reqbufftarget="target" reqbuffcount="1"

can someone explain these options to me?

for me it looks like the target needs to have a (de)buff with count 1 which is checked, so that the skill is used by the bot. but "Shock" does not need any preconditions on the target, it just has a cooldown.
removing these options i can use the skill and my knight uses "Shock".

Thanx
Ric

[lisa]

activates Light Seals on the target. Each Light Seal causes a (Buff7-Time) seconds Stun effect.

My guess is because if you want to use the skill then you probably also want the stun effect and to get the stun effect you need to have Light Seals as a buff on target.
Otherwise it is just doing damage and you may aswell use a skill that does more damage and also has a shorter cooldown, 30 second cooldown is way to much for a skill you are just doing damage with.

So the real question is why isn't it using the skill?
Does the target have any Light Seal stacks?

[Rickster]

oh, thanx lisa,

i did not read the skill description well and was not aware of the light seals.
as i am not verry good into knight stuff, i just wanted to use the skill to quickly get the target to focus me.

i am using the skill to farm some daily stuff and mobs fall down before any light seals are on it, so the skill was never used

i changed skills.xml to have the skill work without the buff check, but bad thing is, that the file now is marked red for svn. anyway to avoid this?

[rock5]

You should be able to change those values in your profile instead. Just add them to the skill in your profile with no values. I'm not 100% sure what they should be set too. Maybe ""?

Code: Select all

		<skill name="KNIGHT_SHOCK"  modifier="" hotkey="MACRO" priority="90" reqbuffname="" reqbufftarget="" reqbuffcount=""/>

[Rickster]

empty strings do not work. also failed with

Code: Select all

=nil

Code: Select all

="nil"

Code: Select all

="0"

Code: Select all

=0

i am out of ideas

[lisa]

I seem to remember Rock telling me a very long time ago that you can't change those values in the profile or maybe it was admin.

[Rickster]

i added a new skill to skills.xml, which is a clone of the original, except i left out these options. works fine for me, only the file is svn red marked, due to the additional code.

Code: Select all

<skill name="KNIGHT_SHOCK" id="490158" mana="25" cooldown="30" range="150" type="damage" target="enemy" reqbuffname="500137" reqbufftarget="target" reqbuffcount="1" />
<skill name="KNIGHT_SHOCK_INSTANT" id="490158" mana="25" cooldown="30" range="150" type="damage" target="enemy" />

[rock5]

I seem to remember Rock telling me a very long time ago that you can't change those values in the profile or maybe it was admin.

You can only change the values that are set up to be overwritten by profile settings. The "reqbuff" values are one of them.

I had a look at the code. I think I understand whats happening. The profile skills settings are read and converted to their types. Eg. numbers are converted to numbers and "" is converted to nil. Then for each value it read from the profile, it overwrites the already loaded skill from the skills database. Unfortunately, when it reads the "" value and converts it to nil, it is actually deleting that entry so it doesn't overwrite the existing value. I'm not sure how to fix this. It might require a whole rewrite of the way it gets and overwrites the profile skill settings.

Actually, just had an idea. The word "nil" isn't supported so we can use that. Set reqbuffname="nil" then in skill:canUse() change

Code: Select all

	if( self.ReqBuffName ~= "" ) then

to

Code: Select all

	if( self.ReqBuffName ~= "" and self.ReqBuffName ~= "nil") then

Just tested it. It worked fine.