----===== new revision of Patch 4.0.6.2483 =====----

[lisa]

yeah feel free to PM me any info you don't want posted and I'll have a look.

[cufRet8e]

I just send you my profile by PM.
Now I had bot crash with Default profile loaded
I was running 2 bots with simple waypoint file, doing harvesting and killing mobs, nothing else, and both bots got crashed (game clients still running).
Output from bot 1 with Default profile (char is mage/priest):

Code: Select all

Moving to waypoint #115, (-15097, 4321)
Stopping waypoint: Target acquired.
Engaging enemy [Kaktus Owocowy] in combat.
Use MACRO: MAGE_FLAME          =>   Kaktus Owocowy (4556/4556)
Use MACRO: MAGE_LIGHTNING      =>   Kaktus Owocowy (0/4556)
Fight finished. Killed 8 Kaktus Owocowy. (fight #32 / runtime 14 minutes)
We didn't move to the loot!? Root buff? Missing 'click to move' option?
Clearing target.
Moving to waypoint #115, (-15097, 4321)
Moving to waypoint #116, (-15211, 4413)
Stopping waypoint: Target acquired before moving.
Engaging enemy [Skorpion ┼╗─ůdl─ůcy] in combat.
Use MACRO: MAGE_FLAME          =>   Skorpion ┼╗─ůdl─ůcy (4695/4695)
Use MACRO: MAGE_FIREBALL       =>   Skorpion ┼╗─ůdl─ůcy (0/4695)
Use MACRO: MAGE_ELEMENTAL_CATAL=>   Skorpion ┼╗─ůdl─ůcy (0/4695)
Fight finished. Killed 4 Skorpion ┼╗─ůdl─ůcy. (fight #33 / runtime 14 minutes)
Clearing target.
Moving to waypoint #116, (-15211, 4413)
Moving to waypoint #117, (-15301, 4508)
Moving to waypoint #118, (-15354, 4570)
Moving to waypoint #119, (-15391, 4654)
Moving to waypoint #120, (-15450, 4764)
Did not find any crashed game clients.
6:5am - X:/Programs/micromacro/scripts/rom/classes/pawn.lua:372: Error in memory
 reading

Output from bot 2 with custom profile (char is rogue/priest):

Code: Select all

Moving to waypoint #16, (-6400, 5538)
Moving to waypoint #17, (-6491, 5535)
Moving to waypoint #18, (-6528, 5453)
Moving to waypoint #19, (-6562, 5357)
Moving to waypoint #20, (-6479, 4740)
Stopping waypoint: Target acquired.
Engaging enemy [Irontail Anteater] in combat.
Moving in | Suggested range: 50 | Distance: 117
Use MACRO: ROGUE_SHADOWSTAB    =>   Irontail Anteater (1637/1868)
Use MACRO: ROGUE_LOW_BLOW      =>   Irontail Anteater (386/1868)
Use MACRO: ROGUE_WOUND_ATTACK  =>   Irontail Anteater (0/1868)
Fight finished. Killed 12 Irontail Anteater. (fight #75 / runtime 21 minutes)
Clearing target.
Clearing target.
Moving to waypoint #20, (-6479, 4740)
Did not find any crashed game clients.
5:59am - X:/Programs/micromacro/scripts/rom/classes/pawn.lua:372: Error in memor
y reading

[rock5]

Any memory reading error usually means there is a problem with the game, either it has crashed or is about to crash. I don't know how you can get memory read errors when using default profile and simple waypoint file and the game doesn't crash.

[lisa]

Yeah no real issues with profile.

you did have a few

Code: Select all

-->

that didn't need to be there but it shouldn't cause any errors.

Profile didn't call anything out of the ordinary.

had onleavecombat with usegoodie and catchcavy, as long as there is nothing wrong in those userfunctions then the profile can't be the issue.

You said works fine when playing manually so probably not a bad client install.
You said crashes in millers and when doing other simple WP.

It is starting to sound to me that either the Rombot files arn't up to date properly, fully SVN reverted.

Or possibly bad Ram which isn't causing an issue with game but seems to cause issues when writing memory for the game.


If it was constant crash when performing a task and no other time then it would be easy to work out the issue. I can't see any constants between the times it has crashed though.

[cufRet8e]

I have done full SVN Revert, all files up to date, except one, which I modified as you see:
http://uploader.hellground.pl/di-M751.png
And another crash with Default profile loaded, running Xaviera daily script (posted here in another topic). I ran Prime95 (it's a benchmark like Memtest, doing very heavy memory usage and 100% CPU usage on all cores). So my computer should be fine, no errors in Prime95, all games working, bloody RoM working, but only without rombot
http://uploader.hellground.pl/di-23Q4.png

[rock5]

Why do your micromacro and game windows have [#] in the title bar?

[cufRet8e]

You are perceptive:) I am running Runes of Magic and rombot under Sandboxie (link http://en.wikipedia.org/wiki/Sandboxie), for my own conveniance. But I tried it hundred times without Sandboxie, same result.

[rock5]

I'm clutching at straws but if micromacro can't read memory maybe your virus software, or something like that, is blocking the memory reads.

[cufRet8e]

OK, antivirus software (AVIRA Free Antivirus) disabled. Testing in progress.

[rock5]

Programs/micromacro/scripts/rom/classes/pawn.lua:372: Error in memory
reading

While doing something else I got this error. Same line number too. Maybe it has something to do with the swim value. It is different than the other pawn values because it's reading a pointer and not just reading an address. Maybe if a mob disappears it errors if trying to read a pointer.

Well we only really need it for the player so can someone who gets this error alot try the following.
1. Find the following 2 lines in pawn.lua around line 372 and delete them.

Code: Select all

	tmp = memoryReadRepeat("byteptr",proc, self.Address + addresses.pawnSwim_offset1, addresses.pawnSwim_offset2)
	self.Swimming = (tmp == 3 or tmp == 4)

2. Around say line 2684 of player.lua add the following.

Code: Select all

	tmp = memoryReadRepeat("byteptr",getProc(), self.Address + addresses.pawnSwim_offset1, addresses.pawnSwim_offset2)
	self.Swimming = (tmp == 3 or tmp == 4)

[cufRet8e]

So, at least I am not alone. And I assume, everything is fine with my system and hardware. I was close to wipe my Windows installation to get rid of those errors, suspecting viruses, system problems, hardware failure, everything...
OK. So. I modified those two files as you said.
After that I run game, start rombot with new-made 9 lvl character:

Code: Select all

Enter the number of the path you want to use and press Enter > 3
You chose 3
Loaded waypoint path l1t_start.xml
No return path with default naming 1-10Pioneers/l1t_start_return.xml found.
We use the normal waypoint path l1t_start.xml now.
Moving to waypoint #1, (-3779, -8480)
Did not find any crashed game clients.
10:30am - ...:/Programs/micromacro/scripts/rom/classes/player.lua:260: Error in memory rea
ding

Failed straight away, as you see. So I run same waypoint again, running for 2 minutes now without crash.

EDIT: Running 2 bots atm, see what else I will find.

Code: Select all

Fight finished. Killed 6 Boar. (fight #7 / runtime 2 minutes)
Target too far away; not looting.
Clearing target.
Moving to waypoint #3, (-1162, -4500)
Moving to waypoint #4, (-973, -4255)
Did not find any crashed game clients.
10:36am - ...:/Programs/micromacro/scripts/rom/classes/player.lua:260: Error in memory rea
ding

Just to confirm: those errors are bot errors, game client still running fine.

[rock5]

Hm... seems to imply that the swim value can't always be read. I always thought that if the pawn exists (ie. the player) then you should be able to read all the player values from memory. There is some memory issue, that I don't understand, happening here.

[cufRet8e]

How to disable reading of swim value? In none of my scripts I use swimming or teleports or flying hacks, so disabling it may temporary resolve problem in my case.

[rock5]

Yes, but if you help me fix it then it will be fixed for everyone.

Ok. Try this. Just replace those 2 lines I had you enter.

Code: Select all

	-- Swimming wont change if it can't be read.
	local swimoffset1 = memoryReadRepeat("int",getProc(), self.Address + addresses.pawnSwim_offset1)
	if swimoffset1 ~= nil and swimoffset1 ~= 0 then
		tmp = memoryReadRepeat("byte",getProc(), swimoffset1 + addresses.pawnSwim_offset2)
		self.Swimming = (tmp == 3 or tmp == 4)
	end

[cufRet8e]

OK so I will help you with it:) If you have any more code to test just let me know.

[rock5]

Yes please. The code I just posted above. Just replace the 2 lines I had you put in player.lua at line 2684

Code: Select all

   tmp = memoryReadRepeat("byteptr",getProc(), self.Address + addresses.pawnSwim_offset1, addresses.pawnSwim_offset2)
   self.Swimming = (tmp == 3 or tmp == 4)

with the code I posted above. It basically just reads the swim value in 2 steps, checking the first value before reading the final value. I'm assuming that the first value is 0 or nil when it errors but I could still be wrong about that, in which case you might still get the error again. No way to check it but to try it.

[cufRet8e]

Running now 3 bots with this new code, from 30 minutes no crash so far.

[rock5]

Cool. Thanks.

[cufRet8e]

Got one.

Code: Select all

Use MACRO: KNIGHT_DISARMAMENT  =>   Wolf Cub (0/143)
Fight finished. Killed 12 Wolf Cub. (fight #18 / runtime 7 minutes)
Clearing target.
Moving to waypoint #1, (-1838, -9833)
Did not find any crashed game clients.
1:12pm - ...:/Programs/micromacro/scripts/rom/classes/player.lua:260: Error in memory read
ing

But that was bot under Sandboxie. Another two without Sandboxie still running, no problems. I will give it some more time.

[rock5]

Hm... wait a second. Line 260 actually looks like it's another problem. So it's not just the swim address.

It looks like your system just can't read the memory sometimes. Are you sure you're not having performance problems? Does the PC ever lock up for a second or 2 or just the game freeze for a bit?

I'm not sure what can cause this. It would be good if someone, who understands memory reading better, would comment.