need testers for new way to handle heal skills

[lisa]

I don't actually play RoM or bot much now days, can I get some people to test this for me.

Basically at the moment the bot deals with healing purely to heal itself, I have rewritten it so that it now also heals other players if it has them targeted.

put the file in rom/classes/ folder and overwrite the existing file. You can always just do a revert with SVN to go back to old copy.

skill.lua

added use of heals on other players instead of just on self

(16.36 KiB) Downloaded 107 times

I have tested this using party bot and it works fine I just want to make sure I haven't messed up with other targets for normal botting, such as NPC's.

You don't need to use any different code or anything but if you use party bot then you can change party.lua as it no longer needs to have the heal skills in the class, it will use the skills from your profile now and also the settings from your profile. like hpper.

party.lua

uses heal skills from profile instead of forcing it to use skills from party class.

(2.87 KiB) Downloaded 119 times

Any issues please post here
thanks

[rock5]

How about friendly buffs? Does the bot cast them on other players too?

[lisa]

yup it always did buffs to friendly targets, it just never healed them

[rock5]

That makes me think of something. Are all heals "friendly"? I don't think they are. You might have to add a check to see if the skills is friendly in the changes you make. Something like

Code: Select all

	if target.Type ~= PT_PLAYER or self.Target ~= STARGET_FRIENDLY then

[lisa]

troubles i see are this,

"holy aura" is self only, so it might see target as 10% hp and use holy aura.

other skill "something source" heals all party in range to full. If target isn't in party and meets requirements to use that skill then it will use it.

There may be other skills along the same lines but in the end it will just use the skill and therefore they will be on cooldown and may not be available when player actually needs it.

I see these as minor issues, with second skill I can't think of why you would be targeting a player not in party unless they cast a buff on you. Chances of you targeting a non party member and their HP being very low is very very small chance.

Holy aura is another issue, but if a party member is under 15% hp there is a good chance they are going to die anyway, usually if the monsters target dies the healer dies very quickly afterwards.

[rock5]

In the end you want to make sure that the person who will recieve the cast (player or target) is the one that is checked.

[lisa]

Anyone notice any issues while using this skill.lua file?

[MiesterMan]

Anyone notice any issues while using this skill.lua file?

Still catching up with my mailboxes and such. I'll test this when I have a chance. Got some family in town this week, I should go visit them since it's a rarity.

[lisa]

I've had the changes running on my bot for a little over 2 weeks now and haven't had any issues but I obviously don't bot everything in the game. Wanted to make sure it didn't cause any issues before commiting.

I'll probably commit the changes to use friend/mob Id's at the same time.

[MiesterMan]

I was wanting to test this but I'm having trouble with my auto-accept invite addon (an in-game addon). I'd be able to make a lot more money if I could get a healer on my main.