Rock5's catchCavy script

[jduartedj]

You're right but the typo I found was "cavyy.address" and not "IgnoreCavyy"! anyway Rock5 you should look it up, maybe it makes a difference?

Well it would as it means it wouldn't work as intended. I've got an update ready including better battling checks but I can't test it until the problems with the inventory are fixed. I'll look into that now.

Have you tried adding my new address for Bagids it should help inventory problems but NOT the stuck problem.
I'll look forward for the update, if you want i can test it myself.

[rock5]

I'll look forward for the update, if you want i can test it myself.

Actually i might take you up on that seeing as i mostly already updated it but didn't get to test it and now can't. I'll have one last look over it tomorrow and send it to you.

[jduartedj]

Great, PM me tomorrow then.

[jduartedj]

Rock5,

I've been using your catch cavy script and it has been doing very well so far in 10 traps got 100% success! luck or not it's a successful result! So after this basic test is there any other particular test you want me to run regarding this?

[jduartedj]

talked a little early as I would have this changed:

Code: Select all

local HerdDist

to at least 50, because It looks like it is following the cavy rather than passing over it! the bot stay almost next to the cavy and it just goes on further away or sideways.

[rock5]

talked a little early as I would have this changed:

Code: Select all

local HerdDist

to at least 50, because It looks like it is following the cavy rather than passing over it! the bot stay almost next to the cavy and it just goes on further away or sideways.

Well you said it was working so maybe you just had bit of lag when it didn't pass the cavy. I'm happy to change it to a more conservative 50 if you have tested it and it works to your satisfaction. Did you test it?

[horsewilly]

Hey, this usually works great, but sometimes (for example if other people try to screw you over), the bot just keeps putting more and more traps. Tonight, for example, it seems the bot used 20 traps, and I caught 3 eggs (from golden cavies). Is there a way to make it use a maximum of about 2 traps by any chance?

[rock5]

Hey, this usually works great, but sometimes (for example if other people try to screw you over), the bot just keeps putting more and more traps. Tonight, for example, it seems the bot used 20 traps, and I caught 3 eggs (from golden cavies). Is there a way to make it use a maximum of about 2 traps by any chance?

Actually if it fails to catch the cavy I'm pretty sure it's supposed to give up and move on, not keep laying traps to try again. I can't think of any way someone could cause you to use up extra traps.

[mayainverse]

im having problems with this. i changed "golden magic cavy" to "magic cavy" to test if it works. and it works fine. but then i swap back to it saying "golden magic cavy" a golden cavy spawned a little bit later and it just ignored it.

[lisa]

Actually if it fails to catch the cavy I'm pretty sure it's supposed to give up and move on, not keep laying traps to try again. I can't think of any way someone could cause you to use up extra traps.

I think he is saying or assumed that the bot would lay another trap if it failed to catch the cavy.
If someone was close by and kept making cavy run from u then you would never catch it.

I'f it lays 1 trap per cavy then purhaps you had 20 golden cavy spawn and only caught 3. Hard to say

[rock5]

im having problems with this. i changed "golden magic cavy" to "magic cavy" to test if it works. and it works fine. but then i swap back to it saying "golden magic cavy" a golden cavy spawned a little bit later and it just ignored it.

I don't know. I can't see what would cause that unless you were just really unlucky. Leave it running overnight or something and see if it catches any cavies.

I'f it lays 1 trap per cavy then purhaps you had 20 golden cavy spawn and only caught 3. Hard to say

Not likely. My experience, you would be lucky to catch 3 Golden Magic Cavies overnight which is why it confuses me. Maybe he just misremembered how many he had.

[horsewilly]

Nope, I'm pretty sure it must have used like 18 at least. This happened to me once before, where I had 28 traps the night before, and when I tried to catch a cavy the next day, I realized that I had no traps left.
Either way, if you say it stops, Ill try to watch next time it makes the cavy sound and see what happens exactly.

[mayainverse]

it works. i guess it does not always find the cavy. but it caught one today by itself. sad thing was it was the 1 most perfect pet i could have had except stats was element fire but needed wind sigh

[sdude13]

I play as mage endlevel, so kills are one hits.
Installed addon on german client and put:

Code: Select all

<onLeaveCombat>
		-- Additional Lua code to execute after killing an enemy
		cprintf(cli.yellow, "check cavy\n");
		catchCavy("Magisches Cavia");
</onLeaveCombat>

in it, the cprintf i did to see if onLeaveCombat is triggered.
it does not catch any cavy.
I tried catchCavy("Magisches Cavia");, catchCavy();, catchCavy("Cavy");

nothing happens, it gives me the "check cavy" message and does nothing.
i changed the addon itself putting

Code: Select all

-- if player.Battling then return end --Don't catch cavy if still battling.

and also

Code: Select all

local cavy = player:findNearestNameOrId(_cavy, player.IgnoreCavy)
	if cavy then cprintf(cli.yellow,"\a\found cavy\n") end
	if cavy and inventory:useItem(206776) then -- Huntsman's Trap

to see if it arrives at that line. it doesnt

[lisa]

If your killing in 1 shot then you could try changing your profile.

Code: Select all

		<option name="COMBAT_DISTANCE"    value="100"

You would atleast be in range of the mob when it dies, which might help it detect the cavy.

[rock5]

First to clarify some things.

As far as I know, there are no distance checks in catchCavy.

Code: Select all

catchCavy()

wont work because it defaults to "Golden Magic Cavy" which is the wrong language. It would have worked if I'd remembered to release my 1.02 version of the script which uses the id instead.

Code: Select all

catchCavy("Cavy") 

wont work again because it's the wrong language.

Code: Select all

catchCavy("Magisches Cavia")

I believe should only catch regular Magic Cavys because golden cavys is spelled with a small "m" in your language.

If you want to catch both regular and golden cavys try

Code: Select all

catchCavy("Cavia")

If it's still not catching the cavies then the following are reasons I can think of why it wouldn't.
1. You don't have any traps.
2. The player has aggro from a mob.
3. The cavy is being ignored because of a previous failed attempt to catch it.

I'll see about uploading my newer version of catchCavy.

[rock5]

Ok, I've uploaded version 1.02.

Main changes:

• catchCavy() has always defaulted to catching only Golden Magic Cavys. I've stated before that it works in any language. Now it really does work in any language.
• catchCavy("cavy") will catch both types of cavy and will work in any client language.
• No longer waits for 1s for the Battling flag to clear so it goes faster.

[sdude13]

tested new version, works like charm (on german client).
did not catch any golden so far but i guess i need more luck (or time hehe)

thank you !

[Auto Pilot]

Just tried the script (setup to catch all cavys for the testing) and it's amazing how nicely it worked (I don't think I ever catched one that fast myself.

Now hopefully my char can catch some golden ones

Edit : after some testing it seem to work pretty nicely ... erm ... perfectly. Every trap that went missing from my bags was replaced by a amazing or holy pet egg (and I didn't see the bot not try to catch a golden cavy, but that's obviously a pretty hard one to check)

[Auto Pilot]

Been reading the code over and over, but I can't find what part of the code rings the bell, wanted to copy that in a script watching some boss spawn for me so I need your help again Rock for this one