Repair dialog window doesn't open.

[Mushroomstamp]

I'm trying to get my character to repair at an NPC, sell all whites under 110 dura, and replenish healing herbs... but I can't even get passed step one. The repair and autosell was working before the newest patch, but I have had no success since. character goes to NPC, targets NPC, but the dialog window never opens, and character moves on to his return path without repairing or selling anything.
Merchant code;

Code: Select all

    <!-- #  9 --><waypoint x="13148" z="6832">
        player:target_NPC("Buruk Wright"); yrest(2000);
        RoMScript("ChoiceOption(1)"); yrest(500);
        RoMScript("ClickRepairAllButton()"); yrest(500);
        RoMScript("CloseWindows()");
    loadPaths("Ravenfellreturn");
    </waypoint>

Autosell options

Code: Select all

<option name="INV_AUTOSELL_ENABLE" value="true" />
<option name="INV_AUTOSELL_FROMSLOT" value="19" />
<option name="INV_AUTOSELL_TOSLOT" value="42" />
<option name="INV_AUTOSELL_QUALITY"	value="white" />
<option name="INV_AUTOSELL_NOSELL_DURA" value="110" />

I have it as player:target_NPC, because player:merchant was not working either. An interesting note, if I put the character in between waypoints 8 & 9, he DOES open a dialog window and repair. Still no selling though. Any help would be appreciated.

[hellburns]

Try this

Code: Select all

<!-- #  9 --><waypoint x="13148" z="6832">
        player:merchant("Buruk Wright"); 
    </waypoint>
<!-- #  10 --><waypoint x="13148" z="6832">
 loadPaths("Ravenfellreturn");
 </waypoint>

this is done automaticaly

Code: Select all

RoMScript("ChoiceOption(1)"); yrest(500);
        RoMScript("ClickRepairAllButton()"); yrest(500);
        RoMScript("CloseWindows()");

and having this in the same waypoint tag as player:merchant() just makes it move straight on to next waypoint

Code: Select all

loadPaths("Ravenfellreturn");

hope this helps

[Mushroomstamp]

Thanks for the suggestion but that didn't work... no repair, no sell, moves on to next waypoint.

EDIT:
Tried it again an hour or so later after adding a yrest, and it worked... sort of. Opened dialog and repaired. After "Mapping inventory" fully once, it stops on an error;
...classes/inventory.lua:379: attempt to compare number with nil
379 in inventory.lua is first line of below code;

Code: Select all

	if self:getItemCount(bestItem) < quantity then
	    numberToBuy = quantity - self:itemTotalCount(bestItem);
	    printf(language[1001]);  -- Shopping
	    for i = 1, numberToBuy, 1 do
	    	RoMScript("StoreBuyItem("..bestItemSlot..")");
	    	printf(".");
		end
		printf("\n");
	end

Can anyone tell me what part of the code needs changed?

[Mushroomstamp]

Guess that one time it worked may have been an anomoly because I'm back to no dialog window. Bot successfully targets merchant NPC and tries to open dialog window... but dialog window never pops up, so repair is not done.

[swietlowka]

i use just player:merchant("Buruk Wright");
but i have streamline addon for the repair, and windows does close it self when you walk away from npc

[Mushroomstamp]

Streamline needs an open dialog window... since the dialog window doesn't open, I wouldn't repair with Streamline either.

[Giram]

You can try to repair using pbinfo too. Type /pbic on rom chat and there somewhere is option that it would repair when you open merchant.

[rock5]

Can I suggest you make sure your SVN Update updated properly?

Look for any files in the rom folder with red icons next to them and right click them and select 'TortoiseSVN/Revert' to revert that file to an exact copy of the current version.