Rock5's Mail Mods

[N1ghtmare]

Well tried re-installing my client and that didnt help either there are 20 mails waiting to be taken but the bot still only takes 9 and closes the mail without deleting any and getting that automation failed message in chat looks like i'll have to do it manually

[rock5]

I didn't find the error the first time I looked but I just tried again and found it. I followed it back a bit. Still doesn't make much sense but I noticed some settings in tools.lua located in UltimateMailMod\Library\.

Code: Select all

UMM_GLOBAL_AUTOMATION_WAITTIME    = 0.3;
UMM_GLOBAL_AUTOMATION_WAITTIMEOUT = 10;
UMM_AUTOMATION_BEFORE_DELETE_WAITTIME = 1.0;
UMM_AUTOMATION_DELETE_WAITTIME    = 0.15;

UMM_GLOBAL_AUTOMATION_WAITTIMEOUT seems to be relevant. I'm not sure what it will do but you could try increasing this value.

[N1ghtmare]

Tried looking into it myself and although im not exactly an expert on all this i found the problem i was having was coming from the userfunction (probably assuming all the mail was gone because the buffer was full so quick) i edited that and now its working fine. Thanks for taking the time to look into it tho.

[rock5]

Tried looking into it myself and although im not exactly an expert on all this i found the problem i was having was coming from the userfunction (probably assuming all the mail was gone because the buffer was full so quick) i edited that and now its working fine. Thanks for taking the time to look into it tho.

Please elaborate. What did you edit and what did it fix? Were you talking about my UMM userfunction or some other userfunction of your own?

[N1ghtmare]

Your userfunction m8, all i did was increase the yrest time after it starts taking mail and that solved the problems i was having

[rock5]

After it starts taking mail the only yrest I see is in the loop that waits for the auto running to finish

Code: Select all

	repeat
		yrest(2000)
		InboxCount = RoMScript("UMMMailManager.MailCount")
		if InboxCount == lastInboxCount then
			-- Stuck
			RoMScript("HideUIPanel(MailFrame)")
			break
		end
		lastInboxCount = InboxCount
	until RoMScript("UMMMailManager.priv_AutoRunning") == nil

Is that the yrest you are talking about? How much did you change it by?

I can imagine how this could cause a problem if it is taking mail slower than 1 every 2 seconds. That's pretty slow though.

[N1ghtmare]

No m8 this is it:

-- Taking mail
local starttimer = os.clock()
repeat
RoMScript("UMMFrameTab1Tools:ButtonClick('take');"); yrest(25000)
until RoMScript("UMMMailManager.priv_AutoRunning") == true or RoMScript("UMMMailManager.MailCount") == 0 or os.clock() - starttimer > 5
local lastInboxCount = RoMScript("UMMMailManager.MailCount")
repeat

changed it to 25000 which gives you enough time to collect 30 items and delete the mail, really speaking its more than is needed but as it doesnt really add anymore time once the mail is empty (ie once it finishes collecting it moves on instead of waiting the full time) i felt it was better to have too much than just have what i needed.

So basically what this is doing for me is if mail is still being collected it waits before trying to do anything else but as soon as there is no mail detected it moves onto the next action instead of waiting, nomore just getting 9 mails and it closing down but also no extra delay if there was only 5 to take so its completely solved my issue.

[rock5]

That looks messed up. That loop is the loop that waits until it starts getting the mail, ie. UMMMailManager.priv_AutoRunning = true. The next loop, the one I showed you, is the one that waits for it to finish, ie. UMMMailManager.priv_AutoRunning = nil.

You said it would collect 9 mails then stop. Did the 9 mails take about 5 seconds to get? If so I think the problem is UMMMailManager.priv_AutoRunning wasn't being set and that first loop would timeout and it would continue. And because UMMMailManager.priv_AutoRunning wasn't being set it doesn't collect anymore mail.

So I'd say the problem is with UMM. Either you are using the wrong version, or it's corrupt somehow, or you have more than one version installed at the same time and they are interfering with each other. Note: if you do have another copy install, such as a back up copy or accidentally making a copy in another addons folder, it will still be installed.

[N1ghtmare]

Yes was closing after a few seconds, i tried both versions of UMM deleting it before i tried the next. I was the same as you and looked at the other part thinking that would be right then read through again and as that rest is immediatly after it calls to take mail i tried that and its working for me at least.

I did think i would have an issue with it tho if i didnt have a full mailbox but that wasnt the case and now its working perfectly.

[ZZZZZ]

How do I change the tryRelog() function so that it just skips mailing all together if mailing halts/fails? Nexon server has the worst mail system I have seen, and quite often alts get stuck mailing, and when they try to relog, it just breaks it so it says "Still cannot do this" and ends up in a constant loop.

[rock5]

I have posted a beta version that is supposed to handle that error.
http://www.solarstrike.net/phpBB3/viewt ... 051#p55051

If you have the login userfunction installed then it restarts the client, otherwise it skips the relog.

[ZZZZZ]

Alright, thanks. Will give it a try.

[Ego95]

rock, I would like to know what I need to change to do something else instead of relogging, when the sending limit is reached. For me, relogging never worked, because my mailbox gets bugged after relogging, so it keeps relogging for hours. When the sending limit is reached you can change the (sub-)zone too, then, you can go on sending too. What I would like to do is to walk to a specific waypoint when the sending limit is reached, then go back and go on sending. How would I need to do this. I already tried to understand how it notices the send limit has reached and relogs, but I didn't find it.

Greets

[rock5]

Firstly, you say the mail bugs after relogging. Is it unable to open the mailbox and says it's already open? If so, that's a bug with the game. If the mailbox isn't closed when you relog then you wont be able to open it after the relog. There is code to close it but maybe you are causing a situation where it misses that step so it bugs.

We could try putting the close mail command right inside the relog function to make sure it does it. At the top of the tryRelog function add this line.

Code: Select all

local function tryRelog()
    while RoMScript ("MailFrame:IsVisible()") do RoMScript("MailFrame:Hide()") end

If that doesn't work, I'll tell you how to make it do something else.

[Ego95]

Okay, the mailbox closes but I'm getting this error:

Code: Select all

Mailing delayed. Reloging before continuing.
The game client did not crash.
2014-01-29 15:17:51 - IGF:\ChangeChar(CHARACTER_SELECT.selectedIndex)\ [string "
?"]:543: attempt to concatenate local 'acctoload' (a nil value)

My ingamefunctions folder is up to date

Edit: Ok something in my character screen was bugged

[rock5]

Edit: Ok something in my character screen was bugged

So does that mean it works or it still doesn't work?

BTW, an error message starting with igf means that it's an error message from the game in response to a command you sent. I couldn't find acctoload anywhere, is that from something you wrote?

[Ego95]

The IFG error had an other unknown reason. Didn't happen again. If it works 100% I still don't know. 240 fusion stones were sent with relogging after about 60 stones each time. But when sending 240 belts the mailbox got bugged again. It closes before relogging and I don't get the "The mailbox is still opened" message anymore. Instead, while the mailbox opens again and it tries to send items I get the message "You still can't do this" >.< The items won't be send and it relogs again.

[rock5]

Is that to different users or the same user? I think there is a limit to how many items you can send to one character before you have to collect. The error message is not very informative, is it? It's possible there is another limit besides the 60 item limit that causes this error. I think it has been reported that restarting the client fixes it. I should probably do some testing and try to resolve it.

[Ego95]

No it is not to the same user. I am sending 10 items to each character, so 240 to 24 characters. You are right, that error message is not really informative, I don't know if I have translated it 1:1 but in german the message sounds funny too, because it's a kind of "duh, I don't let you send anything" message

I am going to test it tomorrow again and I will try to see, what happens exactly. It would not make any sense, but maybe it happens, if you open the mailbox to early after logging in. What I noticed is, that if you open your mailbox or the ah directly after logging in, it may happen, your items in the mailbox and your own auctions in the list are not showed. If you close the mailbox or the ah again, wait a few seconds and open it again, your auctions and mails are there again.

Maybe this has anything to do with that message, I get sometimes, when sending mails after relogging.

[rock5]

That would be easy to test. Next time you get the message, wait a few seconds and try again. Otherwise try what I said, restart the game see if that works. Either way let me know if you find the cause/solution.