Functions in Load are not working. Where is the mistake?

[rock5]

newtime should tell what time the message happened. If it's zero then it isn't detecting the message.

Are you sure it's he right message? Or is it actually "Regional event has ended."? The key string for that is "SC_ZONE_PE_3TH_FAIL".

[Danni]

Code: Select all

"Regional event has ended." = "SC_ZONE_PE_3TH_FAIL"

this message shows up if the char does not manage to finish the event before the time is up.

Code: Select all

"Regional event has ended successfully!" = "SC_ZONE_PE_3TH_ST1OVER"

this message shows up if the char does manage to finish the event before the time is up.

I tried both scenarios, unfortunately the timer still shows ZERO and the Char still keep on doing the quest.

Can it be that the function does not work anymore?

[rock5]

Looks like you were right all along. The messages are warning messages that have had yellow color information added so they look like alert messages. The color information is not part of the TEXT messages but added. This is going to be a hassle because some TEXT texts do have color information as part of the text. So just removing the color info would cause these other strings not to match. I think if situations happen like this where the text is changed then we have to deal with them separately.

In this case try changing back to warning messages and adding the yellow color information like you did a few posts back.

[Danni]

Finally it works now Thx u rock5 One problem finally of the list

Now I still have 2 Questions right now:

1. Is there a code for checking the ZoneID? And depending what ZoneID the Char is, it will do the following commands?

Something similar like Queststate-Check but for the zone? example: "queststate = getQuestStatus(Quest1);"

So I might write a function:

Code: Select all

function Zonecheck()
zonestate = getZoneID()
if getZoneId() == numberA then
		__WPL:setWaypointIndex(__WPL:findWaypointTag("RouteA"));
end
if getZoneId() == numberB then
		__WPL:setWaypointIndex(__WPL:findWaypointTag("RouteB"));
end

this of course does not work. The Question is how I do it?

2. Unstick3() is a function already in MM. My Question is:

• Does Unstick3() is active just by putting the below code in the Load section or do I have to put it into the profile? But I only want this Unstick function to work when I am running that specific script.
  Can I make is lower than 3 like Unstick2 or even Unstick1?

Code: Select all

function unStick3()
   Zonecheck();
   if getZoneId() ~= number(a1) then
      RoMScript("Logout();");
   elseif getZoneId() ~= number(a2) then
      RoMScript("Logout();");
    elseif getZoneId() ~= number(a3) then
      RoMScript("Logout();");
   end      

[rock5]

1. Something like

Code: Select all

function Zonecheck()
   local zonestate = getZoneId()
   if zonestate == numberA then
      __WPL:setWaypointIndex(__WPL:findWaypointTag("RouteA"));
   elseif zonestate == numberB then
      __WPL:setWaypointIndex(__WPL:findWaypointTag("RouteB"));
   end
end

You supply numberA and numberB.

2. unStick3 is executed if it exists so you can create it anywhere such as in the onload of a waypoint. The only valid functions are unStick3(), unStick6() and unStick9().

[Danni]

thx for the fast reply.
Since now everything is running more smoothly, I had the chance to discover a few more strange things ....

Code: Select all

function Zonecheck()
	local zonestate = getZoneId()
   	if zonestate == ZONE-ID then
		doquest()
		people()
		__WPL:setWaypointIndex(2);
		yrest(3000)
		DetectionnameAll()
	elseif zonestate == ZONE-ID then
		doquest()
		people()
		__WPL:setWaypointIndex(2);
		yrest(3000)
		DetectionnameAll()
   	elseif zonestate == ZONE-ID then
		doquest()
		people()
		__WPL:setWaypointIndex(1);
		yrest(3000)	
		Detectionname3()

1. After the doquest() it should check with people(), how many are around by using this code:

Code: Select all

function people()
	if CountPlayers() > 1 then
   		print("Waiting till it's less crowded")
   		repeat
      		yrest(900000)
   		until 0 > CountPlayers(nil,true) 

There were 4 people and nothing happened. I do have the userfunction in my MM. Why Is this code not saying, more than 3 people it should print "Waiting.." and wait 15min? It ignored this function and went directly to DetectionnameAll().

2. I want the Char to go the the WP 1 or 2 first before it does Detectionname function, but strangely it goes directly to Detectionname and ignores the Waypointindex.... for the background WP 1 is further away than WP 2. It somehow stays at WP 2 even in the last loop. What went wrong?

3. Detectionname should check for three specific Masters by using this code:

Code: Select all

function DetectionnameAll()

   	EventMonitorStart("detectMaster", "CHAT_MSG_SYSTEM");
		sendMacro("AskPlayerInfo(\'Master\');"); yrest(1000);
   
		local found = false
   		repeat
      			local time, moreToCome, msg = EventMonitorCheck("detectMaster", "1")
      			if msg and string.find(msg, ".*%(.*%).*%(.*%).*%(.*%).*%(.*%)") then
         			RoMScript("Logout();");
         			break
			end
			if not found then
         			channelAll()
         			break
      			end
   		until moreToCome == false

   	EventMonitorStop("detectMaster")

Today one of the Master was online, so the Search did not fail , but MM did not Logout the Char, as I want it to. Does the Master have to be nearby to work? Because the Master was two Zones away.

My thoughts are now, maybe I did something wrong in the Zonecheck() function, since it only do doquest & DetectionnameAll. It is specially important
in the last loop, since Detectionname3 has includes the restTilEvent() function, which seems not to work either, because it just switch immediately the channel. It it because it ignores the Zonecheck??

Code: Select all

function Detectionname3()

   	EventMonitorStart("detectMaster", "CHAT_MSG_SYSTEM");
   		sendMacro("AskPlayerInfo(\'Nohdrael\');"); yrest(800);
   		sendMacro("AskPlayerInfo(\'Kiareko\');"); yrest(800);
   		sendMacro("AskPlayerInfo(\'Lonarhune\');"); yrest(800);
   
		local found = false
		repeat
      			local time, moreToCome, msg = EventMonitorCheck("detectMaster", "1")
      			if msg and string.find(msg, ".*%(.*%).*%(.*%).*%(.*%).*%(.*%)") then
         			RoMScript("Logout();");
         			break
			end
			if not found then
         			restTilEvent()
				channel()
         			break
      			end
   		until moreToCome == false

   	EventMonitorStop("detectMaster")

Code: Select all

function restTilEvent()
	repeat
	yrest(700)
	until os.date("*t").min%20 == 10
   	
	yrest(10000)
   	local curtime = os.date("*t")
   	local curmins = curtime.min	
	local cursecs = curtime.sec
   	if curmins > 48 then
      		curmins = curmins - 47
   	elseif curmins > 28 then
      		curmins = curmins - 27
   	elseif curmins > 8 then
     		curmins = curmins - 7
   	else
      		curmins = curmins + 10
   	end
   	local resttime = ((20 - curmins) * 60) - cursecs
   	print("resting for "..resttime.." seconds")
   	yrest(resttime*1000)

The timer is written so it should wait until there are 2 min left before the new Event is starting anew. Is that correct?

[rock5]

1. I'm not sure. I can't see anything wrong with it. Maybe you should add (nil,true) to the first CountPlayers to see if it prints anything. Also you could try entering the command from the commandline.

2. It's hard to tell. What values do ZONE and ID have?

3. Those functions don't look like what I helped create. 'found' is never used and the 'if not found then' if statement should go outside the repeat loop. It's supposed to check 'found' after it's finished looking for the gms. Something like this.

Code: Select all

      EventMonitorStart("detectMaster", "CHAT_MSG_SYSTEM");
         sendMacro("AskPlayerInfo(\'Nohdrael\');"); yrest(800);
         sendMacro("AskPlayerInfo(\'Kiareko\');"); yrest(800);
         sendMacro("AskPlayerInfo(\'Lonarhune\');"); yrest(800);
   
      local found = false
      repeat
               local time, moreToCome, msg = EventMonitorCheck("detectMaster", "1")
               if msg and string.find(msg, ".*%(.*%).*%(.*%).*%(.*%).*%(.*%)") then
                  RoMScript("Logout();");
                  found = true
                  break
               end
      until moreToCome == false
      EventMonitorStop("detectMaster")

      if not found then
            restTilEvent()
      channel()
            break
      end

The best way to test the timer is to have it do a print out and see if it prints what you expect.

[Danni]

thx for reply. The Detection function was my mistake. Sry I misunderstood some lines.

1. How do I entering the command from the commandline? I am not sure what you mean
I added (nil, true) and it does print out the names of the nearby players, but it doesn't print "Waiting' nor is make a pause.

2. The Zone-ID are like this:

Code: Select all

function Zonecheck()
   local zonestate = getZoneId()
      if zonestate == 32 then
      doquest()
      people()
      __WPL:setWaypointIndex(2);
      yrest(3000)
      DetectionnameAll()
   elseif zonestate == 1032 then
      doquest()
      people()
      __WPL:setWaypointIndex(2);
      yrest(3000)
      DetectionnameAll()
      elseif zonestate == 2032 then
      doquest()
      people()
      __WPL:setWaypointIndex(1);
      yrest(3000)   
      Detectionname3()

the last loop it should go to WP1, but since the Char is standing at WP2 and it's more nearer than walking to WP1, it is seems to ignore that command. Is there another way to force the char to go to a specific WP?

The WP look like this

Code: Select all

<!-- #  1 --><waypoint x="-9192" z="-18369" y="919" tag="Home">
		player:mount()
		waitForEventStart()
</waypoint>
<!-- #  2 --><waypoint x="-9400" z="-18352" y="933" tag="Start">
	yrest(3000)
	Zonecheck()

[rock5]

1. You haven't heard of my commandline? Shame on you.

Type rom/bot path:commandline in the MM window or double click the "StartCommandLine.bat" in the rom folder.

2. Silly me. I thought they were variables. Now it makes sense.

And now I can see the problem. getZoneId doesn't return the same values as GetZoneID in game. getZoneId returns only the zone id as the first argument. It returns the channel as a second argument, eg,

Code: Select all

zone, channel = getZoneId()

You can then use the channel to make your decision.

[Danni]

1. The great question ...what should I write int the commandline in order to check the people() function?

2. I not quite understand the last part. Do you mean something like this:

Code: Select all

local zone, channel = getZoneId()
   	if zone, channel == 32 then
		doquest()
		people()
		__WPL:setWaypointIndex(2);
		yrest(3000)
		DetectionnameAll()
	elseif zone, channel == 1032 then
		doquest()
		people()
		__WPL:setWaypointIndex(2);
		yrest(3000)
		DetectionnameAll()
   	elseif zone, channel == 2032 then
		doquest()
		people()
		__WPL:setWaypointIndex(1);
		yrest(3000)	
		Detectionname3()

BUt than I got this message on MM:

The game client did not crash.
9:17am - [string "..."]:2: ...icromacro ROM/scripts/rom/waypoints/Testphase -Copy.lua:24: 'then' expected near ','

[rock5]

1. Well, you could test the CountPlayers() function by printing the returned results.

Code: Select all

print(CountPlayers(nil,true))

As far as I can tell your 'people' function doesn't return any values and doesn't print anything so running it from the commandline wont help unless you change it. Also, when you use the commandline the people function wont be available to you unless you temporarily put it in a userfunction for testing.

But I don't think it's necessary. I would suggest adding a print message just inside the function to see when it runs. Something like

Code: Select all

print("'people' now running")

If it runs but doesn't print the "waiting" message then we can be sure 100% that the problem is CountPlayers. That's when it's useful to test CountPlayers in the command line.

2. getZoneId returns 2 values. If you use

Code: Select all

zone = getZoneId()

Then you only get the first value which is the zone. If you use

Code: Select all

zone, channel = getZoneId()

You get both values which are stored in 2 separate variables zone and channel. You want to make the decision based on the channel so you would use

Code: Select all

if channel == 1 then

or if you do want to include the zone (I can't see why you would), you would do

Code: Select all

if zone == 23 and channel == 1 then

This is a syntax error

Code: Select all

if zone, channel == 23 then

BTW if you want to assign multiple values to multiple variables, instead of doing this

Code: Select all

a = 1
b = 2
c = 3

you could do this

Code: Select all

a, b, c = 1, 2, 3

[Danni]

thx u for the reply

About the CountPlayer function .... the problem has been solved. It is now working great. I guess it ignored it before because of the Zonecheck function didn't really work.

The Zonecheck does work now without problems and I learned something new THX U Rock5.

Then you only get the first value which is the zone. If you use

Code:
zone, channel = getZoneId()


You get both values which are stored in 2 separate variables zone and channel.

Just one little thing is still off , after that everything would be perfect. .....

Code: Select all

function restTilEvent()
	repeat
	yrest(700)
	until os.date("*t").min%20 == 10
   	
	yrest(5000)
   	local curtime = os.date("*t")
   	local curmins = curtime.min	
	local cursecs = curtime.sec
   	if curmins > 47 then
      		curmins = curmins - 47
   	elseif curmins > 27 then
      		curmins = curmins - 27
   	elseif curmins > 7 then
     		curmins = curmins - 7
   	else
      		curmins = curmins + 10
   	end
   	local resttime = ((2 - curmins) * 60) - cursecs
   	print("resting for "..resttime.." seconds")
   	yrest(resttime*100)

How does this function work? I try to adjust it a little bit to my understanding, but I got printed a "negative" Resttime and even than it didn't stop resting. The purpose is that I want the Char to rest until it is 3 min before 10, 30 and 50 past each hour. I guess it is also a consideration what time it is on my PC and if it is different to the ROM Time.

[rock5]

I find that too complex. Why not just say

Code: Select all

repeat
    yrest(5000)
    local curtime = os.date("*t")
    local curmins = curtime.min 
until curmins == 7 or curmins == 27 or curmins == 47

[Danni]

lol why easy if it can be complicated

As soon the servers are back I will make the adjustment and try it.

Thx u for the reply

[Danni]

I tried the function. It did work but it has one little downside.

1. If the time on my PC is bigger than MM, it will keep on resting.

Expamle: The Char finish everything at 8 past, which means, it is already overdue the time since the code is curmins == 7.
Instead of "==" is there a code for saying, if it is "bigger or the same" it should do your code above?
I tired using ">" and ">="., but than I get on MM this message:

9:8pm - ...macro ROM/scripts/rom/waypoints/Chrysalia-EoJ_onload.lua:78: attempt to concatenate global 'curmins' (a nil value)

[rock5]

It's not enough to just say > 7 or >= 7 because 26 is also more than 7 and so is 46. The question is at what time do you want it to wait and when do you not want it to wait?

[Danni]

mhm I see.

1. The purpose of the restTilEvent function is to wait for a specific timeframe before doing the next code.

Since the event always starts at 10, 30 and 50 min after each hour (Servertime) I want to wait until the timeframe of 3 min before the Event starts again.
Meaning

Code: Select all

curmins == 7 etc.

does work.

But sometimes the the Char finishes the previous codes after the time in "curmins" like 8 mins or even 9 mins after the hour (the same for 38min/39min or 48min/49min). If that happens, the code above doesn't register the time, since it is not "7 (27/47)" and keep on resting.

So if the time is for example 7,8,9 mins after the hour (same for the 27/28/29 etc) than it should stop the resting and go on with the next code in the script.

2. Another subject, I was wondering about at the same time now is that there are two kind of messages when the event is coming to an end. It is either the Event ended successfully OR it ended (because the time was up).
For the moment the function from previous post before only register the event if it is successful. Is there a way to check for both scenarios with a function?
For example:

Code: Select all

    	local endmsg = getTEXT("|cfffff75Regional event has ended succesfully|r")
       	print("endmsg is ".. endmsg)
	local endmsg2 = getTEXT("|cfffff75Regional event has ended|r")
       	print("endmsg2 is ".. endmsg2)
    	local msgtime = getLastWarning(endmsg) or getLastWarning(endmsg2) or 0
	print("msgtime is ".. msgtime)
      	repeat
        	[i]do something[/i]
               	local newtime = getLastWarning(endmsg) or getLastWarning(endmsg2) or 0
		print("newtime is ".. newtime)
    	until newtime  > msgtime
	print("endmsg detected")

This doesn't work since MM shows that msgtime is the same as newtime and therefore does not stop the loop. How can I rewrite it?

[Bill D Cat]

Perhaps something like this would work?

Code: Select all

if (curmins >= 7 and 10 > curmins) or (curmins >= 27 and 30 > curmins) or (curmins >= 47 and 50 > curmins) then

[rock5]

1. I took too long to answer. But yeah, what Bill D Cat said.

2. getText and the in game function TEXT converts what I call a key strings into a local language text, eg. getTEXT("SC_ZONE_PE_3TH_FAIL") will give you "Regional event has ended.". Giving the function any old text will do nothing to it. So either use

Code: Select all

local endmsg = "|cffffff80Regional event has ended.|r"

or if you want to support other languages use

Code: Select all

local endmsg = "|cffffff80"..getTEXT("SC_ZONE_PE_3TH_FAIL").."|r"

I think you have to record both times

Code: Select all

local msgtime1 = getLastWarning(endmsg) or 0
local msgtime2 = getLastWarning(endmsg2) or 0
print("msgtimes are \n".. msgtime1.."\n"..msgtime2)
repeat
      [i]do something[/i]
      local newtime1 = getLastWarning(endmsg) or 0
      local newtime2 = getLastWarning(endmsg2) or 0
      print("newtimes are\n".. newtime1.."\n"..newtime2)
until newtime1  > msgtime1 or newtime2 > msgtime2

[Danni]

Thanks Bill D Cat for a quicker reply

Everything seems to work like a charm.

Thank you Rock5 so much for your help

P.S. This Thread may be closed now until the Masters are fixing something