Bugs in most recent revision of RoMBot

[KillerTHC]

I was previously having some trouble with RoMBot because it would press enter some time during its session and then it would think it was stuck understand able because now it can't access either the macro or the keyboard to move and it can't even logout! So I updated to make sure I am not missing anything, next thing that happens is this.

The error seems to occur after casting plasma arrow.

Code: Select all

player.lua:549 attempt to call global 'waitTillCastingEnds' (a nil value)

[rock5]

I was previously having some trouble with RoMBot because it would press enter some time during its session and then it would think it was stuck understand able because now it can't access either the macro or the keyboard to move and it can't even logout! So I updated to make sure I am not missing anything, next thing that happens is this.

The error seems to occur after casting plasma arrow.

Code: Select all

player.lua:549 attempt to call global 'waitTillCastingEnds' (a nil value)

Sorry, forgot to prefix that function with "self:". Corrected in rev 463.

That error happened when it was about to use a mana potion. I guess none of my characters used potions while testing.

[KillerTHC]

Any idea why it might have been hitting enter before?

[rock5]

Any idea why it might have been hitting enter before?

I seem to remember Administrator saying it had something to do with the control key being presses while the bot is running.

Let's see what a search reveals. Here we are;
http://www.solarstrike.net/phpBB3/viewt ... ter#p10409

Seems that if you press control while using the computer and the bot send an "s" to the game client, it opens the chat edit bar.

He suggests the solution is to disable the CTRL+S hotkey in-game.

[Starrider]

I have recognized problems with the Urgent heal now. After the "cast"-edit its now hard to cast urgend heal Skill. In trouble situations the prevoius version worked better for me, after the update of rev461+ I don't survived trouble situation anymore, died three times... because the urgend heal doesnt cast corecrtly...
also i have recognized that the bot is a little bit slower, or do i be wrong?

[rock5]

I have recognized problems with the Urgent heal now. After the "cast"-edit its now hard to cast urgend heal Skill. In trouble situations the prevoius version worked better for me, after the update of rev461+ I don't survived trouble situation anymore, died three times... because the urgend heal doesnt cast corecrtly...
also i have recognized that the bot is a little bit slower, or do i be wrong?

It will be hard to work out what could be happening unless you provide more information. Could you please describe how it used to work in the previous version and what happens now differently? Please include an example sequence of spells, any pauses you noticed and if any spells were interrupted.

As to the speed, all tests I did with different spell combination showed that it was significantly faster when using timed spells after another. At worst it should be about the same as the old version when no timed casts follow rimed casts. I did change the pause between instant casts from 500ms to 700ms because I found too many of them were not being cast because it was too fast. Is that what you are talking about? Are you finding your instant casts are taking longer? If so, you have to ask yourself "What's more important, casting a fraction of a second faster but missing a lot of casts or taking a fraction of a second longer but more reliably casting all skills?"

[Starrider]

First this is no negative critic, only feedback, and i hope to improve and support your work. And every system is different so some changes which work well for you must not work fine for others. So i will watch out and test it. But also thanks for your work;

I will test it with both player.lua versions, the other changes made it faster thats right.

will update this post.

update: ok both version work now by constant ping of 47ms with the same speed.

[rock5]

update: ok both version work now by constant ping of 47ms with the same speed.

Great! That's a relief. I'm so proud of the work I've done and hoped no hard-to-reproduce bugs show up and spoil everyone's enjoyment of it.

[KillerTHC]

Found another bug with the waypoint function WPL:setForcedWaypointType("TRAVEL"); when I try to set the waypoint type to travel so I can go and repair I get this error.

Code: Select all

player.lua:924 Error in your profile: onLeaveCombat error: [string "..."]:6: attempt to index global "WPL" (a nil value)

I have also tried the following

Code: Select all

__WPL:setForcedWaypointType("TRAVEL"); -- As seen in the tutorial on the solar strike RoMBot wiki
waypointlist:setForcedWaypointType("TRAVEL"); -- Using the actual class name

[rock5]

The waypoint list is held in object __WPL that's why you got "WPL" (a nil value).

You can't use the class to access the waypoint list as the list is not stored in it.

Code: Select all

__WPL:setForcedWaypointType("TRAVEL");

Should have worked. What happened when you tried it?

[KillerTHC]

Hmm that's odd, when I tried __WPL in an earlier revision I had the same error, however now it works

[rock5]

Hmm that's odd, when I tried __WPL in an earlier revision I had the same error, however now it works

Happy that's sorted out.

"Same error"? Hmm... Maybe you forgot to save.