accept quest by name

[lisa]

JackBlonder has been doing some great work, unfortunately I started it in Rock5's todo list so I decided it would be better to continue discussion in a new topic.

Do you really need to use a second argument?

Not really. I'll change it.

1. RoMScript should be used instead of sendMacro so you don't get so much junk messages and
2. When searching for a quest name, once found it can break from the loop so it stops searching.

OK, I'll change this, too.

[Edit]:
My changed version:

Code: Select all

function AcceptQuestByName(_name)
	
	_name = _name or "All"
	local questToAccept = _name 
	local questOnBoard = ""
	local i
	
	-- Accept all available quests
	if (_name == "" or _name == "All" or _name == "ALL" or _name == "all") then
		printf("We accept all quests\n")
		for i = 1,RoMScript("GetNumQuest(1)") do
			RoMScript("OnClick_QuestListButton(1, "..i..")") -- Clicks the quest
			yrest(100)
			RoMScript("AcceptQuest()") -- Accepts the quest
		end
	
	-- Accept a quest by quest name
	else
		for i = 1,RoMScript("GetNumQuest(1)") do
			questOnBoard = RoMScript("GetQuestNameByIndex(1, "..i..")")
			if questOnBoard == questToAccept then
				RoMScript("OnClick_QuestListButton(1,"..i..")") -- Clicks the quest
				yrest(100)
				RoMScript("AcceptQuest()") -- Accepts the quest
				break
			end
		end
	end
end

function CompleteQuestByName(_name)

	_name = _name or "All"
	local questToComplete = _name
	local questOnBoard = ""
	local i
	
	-- Complete all available quests
	if (_name == "" or _name == "All" or _name == "ALL" or _name == "all") then
		for i = 1,RoMScript("GetNumQuest(3)") do
			RoMScript("OnClick_QuestListButton(3, "..i..")") -- Clicks the quest
			yrest(100)
			RoMScript("CompleteQuest()") -- Completes the quest
		end
	
	-- Complete a quest by quest name
	else
		for i = 1,RoMScript("GetNumQuest(1)") do
			questOnBoard = RoMScript("GetQuestNameByIndex(3, "..i..")")
			if questOnBoard == questToComplete then
				RoMScript("OnClick_QuestListButton(3,"..i..")") -- Clicks the quest
				yrest(100)
				RoMScript("CompleteQuest()") -- Completes the quest
				break
			end
		end
	end
end

What came to my mind though.
Sometimes there are quests where you have to choose a reward.
Any idea on how to implement this?

[JackBlonder]

Thanks lisa.
Here's the userfunction file (is it possible now to name the userfunctions userfunction_xxx.lua instead of addon_xxx.lua?)

[lisa]

I've been testing this and it works great, just a few things that can be improved on.

1. The text for the quest name needs to be exact in every way. Wondering if we can work on making it work if not exact, like search for partial? So "stolen" would still work for "Stolen Tools" or atleast make it so doesn't need to be caps like "stolen tools"

2. Adding in a printf to print in MM window that the quest has been accepted.

3. Add in a printf for when there is no quest matching text.

4. The accept "All" seems to skip some and gets around half available, maybe add in a small pause after each accept?

Edit, yes you can use userfunction_xxx.lua (not plural) and we actually would prefer it =)

[JackBlonder]

I've made some modifications.

1. The text for the quest name needs to be exact in every way. Wondering if we can work on making it work if not exact, like search for partial? So "stolen" would still work for "Stolen Tools" or atleast make it so doesn't need to be caps like "stolen tools"

The function now accepts "Stolen tools", "stolen tools", "sToLEN tOOlS", etc.
Furthermore "-" in questnames are ignored. I'll add other special characters later.
Not done yet: Accepting just a part of the questname (like "stolen").

2. Adding in a printf to print in MM window that the quest has been accepted.

Added.

3. Add in a printf for when there is no quest matching text.

Added.

4. The accept "All" seems to skip some and gets around half available, maybe add in a small pause after each accept?

I changed the routine of accepting and completing.
It now tries to accept until queststate is "incomplete" (means accepted)

Happy bug hunting
Every feedback is welcome

[lisa]

Very nice work yet again, one flaw with the

Code: Select all

until (getQuestStatus(questOnBoard)=="incomplete")

If you already have the requirements to hand in the quest then it hangs indefinately. Might need to add in "or complete" aswell.

Code: Select all

until (getQuestStatus(questOnBoard)=="incomplete") or (getQuestStatus(questOnBoard)=="complete")

I just did it like this, works well.

Rock5 any chance we can have this function added to next revision??

[JackBlonder]

Added this and removed a little copy paste bug.

Code: Select all

until (getQuestStatus(questOnBoard)=="incomplete") or (getQuestStatus(questOnBoard)=="complete")

I'll try to implement word compare now

[Edit]
Word comparison implemented.
Next step: reward selection

Usage:
AcceptQuestByName() --Accept all available quests
AcceptQuestByName("word") --Accept first quest in list with "word" in it's name
CompleteQuestByName() --Complete all available quests
CompleteQuestByName("word") --Complete first quest in list with "word" in it's name

[lisa]

Awesome work yet again
Tested and works perfectly, I'll be the first to admit it is a lot better then I could have done =)

This might be of interest to you
http://www.theromwiki.com/API:SpeakFram ... uestReward

[rock5]

A few comments I'd like to make on this thread.

1. JackBlonder should have started it. Lisa you should have suggested he start a new thread instead of starting it yourself.
2. It should probably be added to the repo page.
3. The first post should be used for releasing new versions.

I'm not sure what should be done. Should I try moving JackBlonders second post to the top? Should he just start a new thread for his "repo" version? Maybe I could just delete Lisas first post so JackBlonder is first?

[lisa]

You are absolutely right Rock5.

I think best way to go forward would be for Jackblonder to create a topic in the userfunctions section and attach his latest file to that post and go from there.
Adding it to the repository is also a very good idea and link it to the new topic in userfunctions section.

[JackBlonder]

No problem. I'll start a new thread and set a link to it here and at the repo page.