Castetime suggestion

Runes of Magic/Radiant Arcana (http://www.runesofmagic.com)
Message
Author
User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: Castetime suggestion

#41 Post by rock5 » Mon Aug 09, 2010 1:13 am

Valleyguy wrote:So could we not just move the value to the players profile and use that above and insert it as code in the profile ...

Code: Select all

<onLoad>
ping = RoMScript("GetPing()")
speedcast = ("ping") - 20 - make sure were safely under the current ping
changeProfileOption("SKILL_USE_PRIOR ", "("speedcast")");
</onLoad>
Or something along this line ... i mean the ping to the servers is pretty stable from what i can see from your end and mine so checking the ping when starting the bot up via the profile should be a easy fix... maybe its getting the code to look for SKILL_USE_PRIOR in the player profile and not in settings.lua now....
If we are going to change the code, why set it up so you have to set the option manually if it could be done automatically?
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

Valleyguy
Posts: 100
Joined: Wed Aug 04, 2010 11:34 pm
Location: Canada

Re: Castetime suggestion

#42 Post by Valleyguy » Mon Aug 09, 2010 1:35 am

True.

This would be mostly automatic unless a player deletes it from his profile just trying to offer other solutions that may reduce coding :)
Image

User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: Castetime suggestion

#43 Post by rock5 » Mon Aug 09, 2010 3:09 am

Valleyguy wrote:True.

This would be mostly automatic unless a player deletes it from his profile just trying to offer other solutions that may reduce coding :)
It's always good to hear different ideas but it would definitely take more coding to move SKILL_USE_PRIOR to the profile and then add a check for it in the code. Much easier to get the ping and then set the value for SKILL_USE_PRIOR when starting the bot.

Plus there is the logic of it. The purpose of profile options is to allow users to customize the values to match the character. SKILL_USE_PRIOR is not a per character setting and doesn't need to be adjustable so there is no reason to put it there.

I really enjoy a good argument but I think we've argued this topic to death. :)

I've sent a PM to Administrator. Hopefully he will comment soon. It should be an easy thing to implement.
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

User avatar
Administrator
Site Admin
Posts: 5331
Joined: Sat Jan 05, 2008 4:21 pm

Re: Castetime suggestion

#44 Post by Administrator » Mon Aug 09, 2010 5:02 am

I've committed this change. You can now use the value "auto" for SKILL_USE_PRIOR (or just remove it from your profile; it'll use this setting automatically) to have it automatically set a value based on your ping. Currently, it's set to ping - 20 with a 25 minimum. Test this out and let me know how it works.

Honestly, this seems a little bit low to me. Most people can expect a ping of ~100, so this would give a SKILL_USE_PRIOR of 80. 80ms isn't going to be very noticeable.

User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: Castetime suggestion

#45 Post by rock5 » Mon Aug 09, 2010 5:33 am

Administrator wrote:I've committed this change. You can now use the value "auto" for SKILL_USE_PRIOR (or just remove it from your profile; it'll use this setting automatically) to have it automatically set a value based on your ping. Currently, it's set to ping - 20 with a 25 minimum. Test this out and let me know how it works.

Honestly, this seems a little bit low to me. Most people can expect a ping of ~100, so this would give a SKILL_USE_PRIOR of 80. 80ms isn't going to be very noticeable.
Valleyguy did do some extensive testing to find his best value of 90 (he has an average ping of 93). My best value is around 375 and my ping is 390. So is seems to be true.

What we really need is for people to test the new revision and report back on their results.
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

Valleyguy
Posts: 100
Joined: Wed Aug 04, 2010 11:34 pm
Location: Canada

Re: Castetime suggestion

#46 Post by Valleyguy » Mon Aug 09, 2010 7:19 am

Administrator wrote:I've committed this change. You can now use the value "auto" for SKILL_USE_PRIOR (or just remove it from your profile; it'll use this setting automatically) to have it automatically set a value based on your ping. Currently, it's set to ping - 20 with a 25 minimum. Test this out and let me know how it works.

Honestly, this seems a little bit low to me. Most people can expect a ping of ~100, so this would give a SKILL_USE_PRIOR of 80. 80ms isn't going to be very noticeable.
its not as much a big deal to notice the speed casting as much as setting this value differs form connection client to connection client and one value (in my case 475) breaks the bot and incurs a lot of fail casting. this is all server dependent i have checked other servers and on one of them i think its one of the pvp i get pings over 250 its the higher pings that will benefit from this more so they can continue to maintain the dps of the low ping clients.
Image

Post Reply

Who is online

Users browsing this forum: Semrush [Bot] and 0 guests