Changelog 745 (RC3)

[botje]

Code: Select all

Use MACRO: WARRIOR_SHOUT       =>   Plump Hare (114550/127221)
Use MACRO: WARRIOR_SHOUT        undercut GCD by 0.1=>   Plump Hare (114550/12722
1)
Use MACRO: WARRIOR_SLASH       =>   Plump Hare (97171/127221)
Use MACRO: WARRIOR_TACTICAL_ATT undercut GCD by 0.4=>   * Failed to cast *
Use MACRO: WARRIOR_SLASH       =>   Plump Hare (76986/127221)
Use MACRO: WARRIOR_TACTICAL_ATT undercut GCD by 0.3=>   * Failed to cast *
Use MACRO: WARRIOR_SLASH       =>   Plump Hare (56988/127221)
Use MACRO: WARRIOR_TACTICAL_ATT undercut GCD by 0.4=>   * Failed to cast *
Taking too long to damage target, breaking sequence...
Clearing target.
Current fight aborted.
We overrun waypoint #20, skip it and move on to #21

still does it rock

[rock5]

Where's the debug printout? I noticed that Tactical Attack keeps failing. Are you using a 2 handed weapon?

[nightclaw]

well Chop 4 the warden now has a CD of 15 secs and other have changed

[rock5]

well Chop 4 the warden now has a CD of 15 secs and other have changed

I noticed that too but I didn't think the old CD was 7s. Ah, it's listed under S/Wd so maybe it only applies to that combo.

[botje]

Where's the debug printout? I noticed that Tactical Attack keeps failing. Are you using a 2 handed weapon?

no debug was given rock, and yes, i use 2handed

[rock5]

no debug was given rock, and yes, i use 2handed

Then it must be from where that message is used in player:fight. Only real difference there is it also checks player.LastHitTime. I'm pretty sure if that failed to read memory it would have errored. This is after that change I asked you to do in pawn.lua, right? Then it's likely a time based break. Try increasing the value of MAX_FIGHT_TIME. Just add it in the option section of your profile and make it something like 10. I might have made it too low.

Code: Select all

		<option name="MAX_FIGHT_TIME"     value="10" />

I still think it might be an issue with reading memory. Make sure you have video settings on low and you don't run any memory or cpu intensive processes while it's running.

[botje]

lol, thats needed? i always play on high

ok, ill check.

max fight time is allready there set to 15 O.o

[rock5]

If you are not already aware, I posted a couple of updated files for the beta to support the 5.0.4 patch. You can find them here
http://www.solarstrike.net/phpBB3/viewt ... 543#p43543

[botje]

Code: Select all

Use MACRO: WARRIOR_TACTICAL_ATT=>   Plump Hare (235187/254442)
Use MACRO: WARRIOR_SHOUT       =>   Plump Hare (235187/254442)
Use MACRO: WARRIOR_PROBING_ATTA undercut GCD by 0.3=>   * Failed to cast *
Use MACRO: WARRIOR_PROBING_ATTA=>   Plump Hare (220665/254442)
Use MACRO: WARRIOR_OPEN_FLANK   undercut GCD by 0.3=>   * Failed to cast *
Use MACRO: WARRIOR_OPEN_FLANK  =>   Plump Hare (201945/254442)
Use MACRO: WARRIOR_TACTICAL_ATT undercut GCD by 0.1=>   Plump Hare (201945/25444
2)
Use MACRO: WARRIOR_PROBING_ATTA=>   Plump Hare (180721/254442)
Use MACRO: WARRIOR_OPEN_FLANK   undercut GCD by 0.3=>   * Failed to cast *
Taking too long to damage target, breaking sequence...
Clearing target.
Current fight aborted.
[DEBUG] 0 target dist > MAX_TARGET_DIST to waypoint

even on low it does it >.<

[cokebot]

inventory:update();
if(3 > inventory:itemTotalCount(0)) then

don't work anymore.

[rock5]

inventory:update();
if(3 > inventory:itemTotalCount(0)) then

don't work anymore.

Yes it does.

[nightclaw]

been geting these from it on the beta side only


have no clue why nothing changed and done these on 3 diff chars my rogue scout my warden as seen here and my champ/rogue

[rock5]

That's one I haven't seen before. If it was a problem with the coding then there would be some sort of pattern. But it if happens with different characters and different skills then I think you're just having problems reading memory.

Try this. Change the following line in skill.lua at around line 742.

Code: Select all

		if offset ~= 0 then

to

Code: Select all

		if offset and offset ~= 0 then

But just keep in mind that CSkill:remainingCooldown() will return a wrong value in those times it would have errored, so it might be the cause of some future casting issues.

[botje]

Code: Select all

Engaging enemy [Mutated Wolf] in combat.
We begin the fight with ranged pulling.
Use MACRO: WARRIOR_SURPRISE_ATT=>   * Failed to cast *
Use MACRO: WARRIOR_SURPRISE_ATT=>   * Failed to cast *
Use MACRO: WARRIOR_SURPRISE_ATT=>   * Failed to cast *
Use MACRO: WARRIOR_SURPRISE_ATTDid not find any crashed game clients.
11:28pm - ...rs\Damian666\Dropbox\micromacro\scripts\beta/bot.lua:604: onLoad er
ror: ...66/Dropbox/micromacro/scripts/beta/classes/skill.lua:740: attempt to per
form arithmetic on a nil value

got it too O.o

[rock5]

got it too O.o

Try the above fix.

[nightclaw]

I put your fix in and i still get the eroor just not as much maybe one to 2 x a day

[rock5]

I put your fix in and i still get the eroor just not as much maybe one to 2 x a day

I don't think it's possible to get that error with that fix in place. Are you sure it's not a different error?

[rock5]

I still sometimes have problems undercutting skills properly. Some skills seem to need to be undercut by a lot to be continuously casting, while others seem to work really well just undercutting by a bit.

I'm thinking of completely changing the way it casts. At the moment, getting the timing right is very tricky and takes a lot of code. But now that I am getting the cooldown for each skill from memory, I can tell when every skill starts casting. All skills either have a cast time, a cooldown or trigger the global cooldown. So what I was thinking is when it goes to cast it should just keep spamming the button until it detects the cast has successfully started before looking for the next skill to cast. That way it will be a lot simpler and the undercutting (ie. the casting speed) will be more reliable and faster. The only downside is it might occasionally cast a skill twice.

If I do this, I'm still not sure if I'll do it now or if I should wait until I do the next update where I plan to get more skill stuff from memory. I'm leaning towards later because I want to get this version committed and out of the way.

[nightclaw]

I put your fix in and i still get the eroor just not as much maybe one to 2 x a day

I don't think it's possible to get that error with that fix in place. Are you sure it's not a different error?

Yes same error i get but just happens way later....and less often

I still sometimes have problems undercutting skills properly. Some skills seem to need to be undercut by a lot to be continuously casting, while others seem to work really well just undercutting by a bit.

I'm thinking of completely changing the way it casts. At the moment, getting the timing right is very tricky and takes a lot of code. But now that I am getting the cooldown for each skill from memory, I can tell when every skill starts casting. All skills either have a cast time, a cooldown or trigger the global cooldown. So what I was thinking is when it goes to cast it should just keep spamming the button until it detects the cast has successfully started before looking for the next skill to cast. That way it will be a lot simpler and the undercutting (ie. the casting speed) will be more reliable and faster. The only downside is it might occasionally cast a skill twice.

If I do this, I'm still not sure if I'll do it now or if I should wait until I do the next update where I plan to get more skill stuff from memory. I'm leaning towards later because I want to get this version committed and out of the way.

i think that well be way better and faster thats how most real players hit keys any how spam 1 tell goes off then spam next so on...that well be super if you add it i my self cant wait

[rock5]

Yes same error i get but just happens way later....and less often

Are you sure it's not a different line number or something because I'm telling you it's impossible to get that error there.

Code: Select all

		if offset and offset ~= 0 then
			return (memoryReadRepeat("int", getProc(), addresses.staticCooldownsBase + (offset+1)*4) or 0)/10
		end

If offset is nil then it wont do that line so it's impossible to get the "attempt to perform arithmetic on a nil value" error for that line. If you are getting that error for that line then I can't explain it.