Mana Stone Tier Production Factory Now V2.5 06/08/2014

[Eggman1414]

it might be, it does an initial grab of items. like 4-5 items then waits. That's what is closing the mailbox.

[rock5]

Have you tried increasing the yrest on line 220 of the userfunction?

Code: Select all

	local lastInboxCount = RoMScript("UMMMailManager.MailCount")
	repeat
		yrest(2000)           -- Line 220
		InboxCount = RoMScript("UMMMailManager.MailCount")
		if InboxCount == lastInboxCount then

[Eggman1414]

May I ask why is there a yrest statement there? Wouldnt it be easier to have a if/until function there? like if there is mail then collect until mail =0? something like that.

[rock5]

I don't remember but there is a comment there that says "-- Stuck" so I assume it's for handling when it gets stuck.

[cowbot7]

A I'm not sure what the problem is. It doesn't seem like it takes 2 secs per item its definitely less, but i did try changing the 2 sec (line 641) delay in rock5 UMM userfunction.lua it didn't help. the mailbox faults out and then u just stand there waiting on the 25 sec delay not sure why this is happening the sending portion of UMM works fine its the receiving part that's messed up.

[rock5]

What do you mean "the mailbox faults out"? Please be more specific. Does the mailbox close then it waits the 25s? Do you get an error message?

[cowbot7]

The ROM chat box reads [UMM] Automation process failed - process halted. I changed line 641 in UMM userfunction back to orginal 2sec value. gonna try adjusting the line 210 value.

[cowbot7]

Got UMM to take 20 items had to change 3 things in UMM userfunction they need more adjustment but atleast it is working now.Altered alues are in RED color.
line 203 -- Taking mail
local starttimer = os.clock()
repeat
RoMScript("UMMFrameTab1Tools:ButtonClick('take');"); yrest(1000)
until RoMScript("UMMMailManager.priv_AutoRunning") == true or RoMScript("UMMMailManager.MailCount") == 0 or os.clock() - starttimer > 50
local lastInboxCount = RoMScript("UMMMailManager.MailCount")
repeat
yrest(20000)
InboxCount = RoMScript("UMMMailManager.MailCount")
if InboxCount == lastInboxCount then
-- Stuck
RoMScript("HideUIPanel(MailFrame)")
break
line 216 end


line 638 -- Waiting until finished
local st = os.clock()
repeat
yrest(20000)
if getLastWarning(getMailboxFullString(), os.clock()-st) then
inventory:update()
cprintf(cli.lightgreen,"Recipient's bags are full.\n")
return false, "Recipient's bags are full"
line 646 end

[rock5]

You're confusing me with those line numbers but if the addon fails then there is probably nothing you can do from the userfunctions to make it work other than reruning the function.

The error seems to have something to do with a timeout. It's a bit hard to follow but you could try changing UMM_GLOBAL_AUTOMATION_WAITTIMEOUT to a larger value. I think that's the value involved. It's found on line 108 of tools.lua in UltimateMailMod\Library folder. You could also try increasing UMM_GLOBAL_AUTOMATION_WAITTIME.

[cowbot7]

I will try out your suggestions Rock5 but right now i have to be getting back on my work schedule witch is very time consuming it maybe a few days before i get back into testing out thoughts out so don't think of me as rude and blowing off. I will say your help is always appreciated thank you ROCK5!

[rock5]

That's ok. When I expect a reply I usually forget about it until there is a new post anyway.

[EastWood915]

Hello, I have a little problem with this stuff:

I want the bot only to do the dailies, switch to another char/aaccount and repeat. So I have removed a bit of code from Daily.xml. It seems to work fine at the beginning, but after doing 10 dailies it keeps on running around instead of switching to another char.

Here's my edited Daily.xml:

Code: Select all

      NpcID = 112794
      QName = "Helping Them Grow" 
	  
	function relog()						<!--Put your Character list here see http://www.solarstrike.net/phpBB3/viewtopic.php?f=27&t=1245 for more info-->
         SetCharList({{
            {account=46 , chars= {}},
            {account=56 , chars= {}},
            {account=67 , chars= {}}

        }})
         LoginNextChar()
         yrest(3000)
         player:update()
         loadProfile()
         loadPaths("Daily.xml");
	end
											<!-- Uses botje's cleanbag functions, see http://www.solarstrike.net/phpBB3/viewtopic.php?f=27&t=2849 for more info -->
		function kill_stupid_newbie_pet()
			if player:findNearestNameOrId(113199) then  -- search vicinity for Newbie Pet
				inventory:update()
				if (inventory:itemTotalCount(207051) > 0) then
					inventory:useItem(207051)
					local newbEgg = inventory:findItem(207051); -- Newbie Pet Egg
					if newbEgg ~= nil then
						inventory:deleteItemInSlot(newbEgg.SlotNumber)
					end
				end
			end
		end
											<!-- Uses botje's cleanbag functions, see http://www.solarstrike.net/phpBB3/viewtopic.php?f=27&t=2849 for more info -->		
		function delete_atonement_voucher()
			if (inventory:itemTotalCount(207082) > 0) then
				local voucher = inventory:findItem(207082); -- Atonement Voucher
				if voucher ~= nil then
						inventory:deleteItemInSlot(voucher.SlotNumber)
				end
			end
		end
</onLoad>
<!-- # 1 --><waypoint x="31847" z="4592" tag ="Main">
	kill_stupid_newbie_pet();
	delete_atonement_voucher();
      if player.Level == 1 then
	  loadPaths("Pre_Daily.xml");
	  end
	  
	  local queststate = getQuestStatus(QName);
      if queststate == "complete" then
         player:target_NPC(NpcID);
         CompleteQuestByName(QName);
         yrest(300);
      end
      
      local dqCount, dqPerDay = RoMScript("Daily_count()");
      if dqPerDay == dqCount then      
         phirCoins = inventory:itemTotalCount(203038)
         print("We have "..phirCoins.." phirius coins")
         
      else
         player:target_NPC(NpcID);
         AcceptQuestByName(QName,NpcID);
         yrest(300);
      end
   </waypoint>
   <!-- #  3 --><waypoint x="31860" z="4646" y="9">   </waypoint>
   <!-- #  2 --><waypoint x="31742" z="5070" y="-11">   </waypoint>
   <!-- #  1 --><waypoint x="31416" z="5715" y="-33" tag = "Item">   
      queststate = getQuestStatus(QName)
      if queststate == "incomplete" then
         player:target_Object(112976,300);
         yrest(2500);
         __WPL:setWaypointIndex(__WPL:findWaypointTag("Item"));
      end
    </waypoint>
   <!-- #  1 --><waypoint x="31416" z="5715" y="-33">   </waypoint>
   <!-- #  2 --><waypoint x="31742" z="5070" y="-11">   </waypoint>
   <!-- #  3 --><waypoint x="31860" z="4646" y="9">   </waypoint>
   <!-- #  4 --><waypoint x="31847" z="4583" y="9">   </waypoint>
</waypoints>

I would be very grateful if you helped me with this problem.

[rock5]

You create the relog function in the onload but you never run it. When you finish the dailies, run relog(). At the moment it just prints how many Phirius Coins you have.

Also I noticed if the character is level 1 it loads the waypoint file "Pre_Daily.xml". You need to know that it will still finish the rest of the code at that waypoint before using the new waypoint file. If you want it to immediately start with the new file add a return just after the loadPaths and it will skip the rest of that waypoint code.

[noobbotter]

Looks like you are missing the line that would actually call the relog() function.

In this code, inside the 1st waypoint, I added two comments and inserted a call to the relog function in the correct spot. I also added Rock5's recommendation of a return if the character is level 1:

Code: Select all

<?xml version="1.0" encoding="utf-8"?><waypoints>
<onLoad>
	NpcID = 112794
    QName = "Helping Them Grow"
    
   function relog()                  <!--Put your Character list here see http://www.solarstrike.net/phpBB3/viewtopic.php?f=27&t=1245 for more info-->
         SetCharList({{
            {account=46 , chars= {}},
            {account=56 , chars= {}},
            {account=67 , chars= {}}

        }})
         LoginNextChar()
         yrest(3000)
         player:update()
         loadProfile()
         loadPaths("Daily.xml");
   end
                                 <!-- Uses botje's cleanbag functions, see http://www.solarstrike.net/phpBB3/viewtopic.php?f=27&t=2849 for more info -->
      function kill_stupid_newbie_pet()
         if player:findNearestNameOrId(113199) then  -- search vicinity for Newbie Pet
            inventory:update()
            if (inventory:itemTotalCount(207051) > 0) then
               inventory:useItem(207051)
               local newbEgg = inventory:findItem(207051); -- Newbie Pet Egg
               if newbEgg ~= nil then
                  inventory:deleteItemInSlot(newbEgg.SlotNumber)
               end
            end
         end
      end
                                 <!-- Uses botje's cleanbag functions, see http://www.solarstrike.net/phpBB3/viewtopic.php?f=27&t=2849 for more info -->      
      function delete_atonement_voucher()
         if (inventory:itemTotalCount(207082) > 0) then
            local voucher = inventory:findItem(207082); -- Atonement Voucher
            if voucher ~= nil then
                  inventory:deleteItemInSlot(voucher.SlotNumber)
            end
         end
      end
</onLoad>
<!-- # 1 --><waypoint x="31847" z="4592" tag ="Main">
	kill_stupid_newbie_pet();
	delete_atonement_voucher();
	if player.Level == 1 then
		loadPaths("Pre_Daily.xml");
		return
	end
    
	local queststate = getQuestStatus(QName);
	if queststate == "complete" then
		player:target_NPC(NpcID);
		CompleteQuestByName(QName);
		yrest(300);
	end

	local dqCount, dqPerDay = RoMScript("Daily_count()");
	if dqPerDay == dqCount then     -- ****************** If this is true, then you are done with your 10 daily quests
		phirCoins = inventory:itemTotalCount(203038)
		print("We have "..phirCoins.." phirius coins")
		relog()                           --****************** I added this line.
	else
		player:target_NPC(NpcID);
		AcceptQuestByName(QName,NpcID);
		yrest(300);
	end
   </waypoint>
   <!-- #  3 --><waypoint x="31860" z="4646" y="9">   </waypoint>
   <!-- #  2 --><waypoint x="31742" z="5070" y="-11">   </waypoint>
   <!-- #  1 --><waypoint x="31416" z="5715" y="-33" tag = "Item">   
	queststate = getQuestStatus(QName)
	if queststate == "incomplete" then
		player:target_Object(112976,300);
		yrest(2500);
		__WPL:setWaypointIndex(__WPL:findWaypointTag("Item"));
	end
    </waypoint>
   <!-- #  1 --><waypoint x="31416" z="5715" y="-33">   </waypoint>
   <!-- #  2 --><waypoint x="31742" z="5070" y="-11">   </waypoint>
   <!-- #  3 --><waypoint x="31860" z="4646" y="9">   </waypoint>
   <!-- #  4 --><waypoint x="31847" z="4583" y="9">   </waypoint>
</waypoints>

[EastWood915]

rock5, noobbotter - now it works perfectly! Thank you very much for amazingly quick answer!

[famousk]

this is a great! group of waypoints, thank you eggman =]. the only problem i have is when the bot goes to clear the mail after it's finished with daily quests, it only opens the mailbox for about 5 seconds so i can't get all the belts and fusion stones i only get like 5 belts before the mailbox close

i just saw Cowbots edit it works now =] but it only deletes half of the empty mails

[rock5]

Sounds like a bug I fixed here. http://www.solarstrike.net/phpBB3/viewt ... 309#p58309. Try that version and tell me if it works.

[famousk]

Sounds like a bug I fixed here. http://www.solarstrike.net/phpBB3/viewt ... 309#p58309. Try that version and tell me if it works.

i used cowbots edit to the umm userfunction and it works now but it only clears half of the mailbox after its done talking the belts and fusion stones

[rock5]

Try my version. I think that will fix it completely.

[famousk]

Try my version. I think that will fix it completely.

Your version works great think i have everything running 100% now =] thanks!!