faster looting, a lot of bodies

Runes of Magic/Radiant Arcana (http://www.runesofmagic.com)
Message
Author
User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: faster looting, a lot of bodies

#21 Post by rock5 » Thu Jun 14, 2012 12:23 pm

The bot doesn't wait for bodies to disappear. As soon as it is no longer lootable, it continues. Maybe it is some other delay. Maybe your lag is increasing.
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

User avatar
dap
Posts: 23
Joined: Thu Aug 11, 2011 1:44 am

Re: faster looting, a lot of bodies

#22 Post by dap » Thu Jun 14, 2012 6:13 pm

i should try to revert modified files.

but i think the better option is to use magic perfume


lags are not possible. It looks like bot waiting after body dissapear, it always looks the same so this is no lag, waits always the same time.
looks like something tells him that body is lootable until dissapear, but i dont know what is responsible for that.

User avatar
silinky
Posts: 213
Joined: Mon Nov 23, 2009 5:07 am

Re: faster looting, a lot of bodies

#23 Post by silinky » Fri Jun 15, 2012 4:53 am

i have that too.
i will tell you what i have done. (don't remember the code i am at work)

onLeaveCombat:
-> check for mobs in an area of 90 and kill them before looting
(this loops until there are mobs in that area)
-> clean the bag

now, when it finishes to kill mobs, it just clears a lot of targets, and wastes about 3-5 seconds after each mob group.
the mm window looks like this after mobs are killed and looting:
"Clear target"
"Clear target"
"Clear target"
"Clear target"
"Clear target"

the number usually varies, for 2 mobs i get it like 3 times, for 5 mobs 6-7 times, dunno exactly.

is that normal? how can i prevent it?

User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: faster looting, a lot of bodies

#24 Post by rock5 » Fri Jun 15, 2012 5:51 am

silinky wrote:now, when it finishes to kill mobs, it just clears a lot of targets, and wastes about 3-5 seconds after each mob group.
is that normal? how can i prevent it?
Seeing as you use custom code for fighting there is probably something wrong there.
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

User avatar
dap
Posts: 23
Joined: Thu Aug 11, 2011 1:44 am

Re: faster looting, a lot of bodies

#25 Post by dap » Fri Jun 15, 2012 8:42 am

Could it be that a longer time corresponding to the memory address ?

Code: Select all

	pawnLootable_offset = 0x38C,

User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: faster looting, a lot of bodies

#26 Post by rock5 » Fri Jun 15, 2012 9:06 am

I did a test and timed how long it takes to become non lootable after looting a body. It took about 1.5s. That's the time it takes to bend over and stand up again. The moment it finished standing it was ready to continue.
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

User avatar
silinky
Posts: 213
Joined: Mon Nov 23, 2009 5:07 am

Re: faster looting, a lot of bodies

#27 Post by silinky » Fri Jun 15, 2012 9:21 am

thank you for the answer. i will get home soon and i can show you the exact code, if needed.
i am suspecting:
1. the bot does not loot the killed mobs until he kill all in area, so he cjecks for loot even for those not lootable, and wastes time figuring that out
2. it somehow accumulates targets and clears them separately, but seems like stupid idea from my part

anyway, when i get home i will provide more test results, because i want to speed up my runs, and have to use speedhack where it is safe, so that i recover the time lost on looting (when fighting and looting the server does not pull me back if i run too fast, only if i run non stop for a distance greater than 250)

User avatar
dap
Posts: 23
Joined: Thu Aug 11, 2011 1:44 am

Re: faster looting, a lot of bodies

#28 Post by dap » Fri Jun 15, 2012 10:08 am

Code: Select all

			-- Wait for character to finish standing
			local starttime = os.clock()
			self:update()
			while self.Stance ~= 0 and 2 > (os.clock() - starttime) do
				yrest(50)
				self:update()
			end
		end
with using flyloot option

Code: Select all

while self.Stance ~= 0 and 2 > (os.clock() - starttime) do
function self.Stance always return 1 so character waits longer than its needed

Code: Select all

			-- Wait for character to finish standing
			local starttime = os.clock()
			self:update()
			if settings.profile.options.FLYLOOT == true then
				self.Stance = 0
			end;
			while self.Stance ~= 0 and 2 > (os.clock() - starttime) do
				yrest(50)
				self:update()
			end
		end
i modified code like that and now it works great. Char looting in miliseconds with lootomatic

thank you for the hint
regards

User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: faster looting, a lot of bodies

#29 Post by rock5 » Fri Jun 15, 2012 10:26 am

Nice theory. I checked with my bot doing KS flying. Stance is always 0 so that's not the problem. Had a thought, checked on a server updated to chapter 5 and it looks like Stance doesn't work at all.

Good work on finding the problem. I'll see if I can fix it.
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

User avatar
rock5
Posts: 12173
Joined: Tue Jan 05, 2010 3:30 am
Location: Australia

Re: faster looting, a lot of bodies

#30 Post by rock5 » Fri Jun 15, 2012 11:42 am

Fixed Stance and ActualSpeed, which was also wrong. Added patterns for them in update.lua so hopefully they will get updated next time.
So do an SVN Update.
  • Please consider making a small donation to me to support my continued contributions to the bot and this forum. Thank you. Donate
  • I check all posts before reading PMs. So if you want a fast reply, don't PM me but post a topic instead. PM me for private or personal topics only.
  • How to: copy and paste in micromacro
    ________________________
    Quote:
    • “They say hard work never hurt anybody, but I figure, why take the chance.”
          • Ronald Reagan

User avatar
silinky
Posts: 213
Joined: Mon Nov 23, 2009 5:07 am

Re: faster looting, a lot of bodies

#31 Post by silinky » Sat Jun 16, 2012 10:16 am

this fixed for me too :)

Post Reply

Who is online

Users browsing this forum: Ahrefs [Bot], Google [Bot] and 3 guests