Problem with LOS (Line of sight) when mounted

[Shogun]

It happens quite often that the bot is not able to attack or fight back when mounted. Previously the character automatically was unmounted, with LOS it gets a lot of hits until the mount occasionally does not block the line. The bot now better should unmount at the begin of the attack.

[rock5]

I haven't noticed that happening and I have been starting attacks mounted.

Does it happen with all mobs or certain mobs? Does it happen with all mounts or only certain mounts.

[Shogun]

I noticed this several times at the butterflies. The mob is in front of the mount, attacks and the character moves backwards with every hit. There is repetitive this message "line of sight blocked". I usually ended this by unmounting manually. There may be a difference by the kind of mount, I only have pegasus.

[rock5]

Can you get your hands on a temp mount?

[Shogun]

Changing the mounts is no option, I have mounts that can walk on water. I will now solve this with a call to CancelBuff() when entering the butterfly area. The described behaviour looks too bottish and low level chars do not survive.

[rock5]

Changing the mounts is no option, I have mounts that can walk on water. I will now solve this with a call to CancelBuff() when entering the butterfly area. The described behaviour looks too bottish and low level chars do not survive.

I didn't mean permanently, I meant just to test if the problem is your mount. I actually tested a pegasus I had with one of my characters. Still had no issues but it was the older type that doesn't walk on water.

Anyway, cancelling the horse is easy enough.

[Shogun]

I've added

Code: Select all

player:dismount()

to revision 690. Enjoy.

Nice to have that now, thanks rock!

To solve the described problem you can add a dismount call in CPlayer:fight()

Code: Select all

	-- Prep for battle, if needed.
	--self:checkSkills();

	self:dismount();

--	local target = self:getTarget();  / double

I added an unmount function about 4 weeks ago, did not make it public because you have to add your mounts to a mounts table. If anyone is interested, but i recommend to use rock's function:

Code: Select all

function CPlayer:unmount()
	if( not self.Mounted ) then return; end

	local mounts_table = {
		{ MountName="Flying Rune Disk (Permanent)", ID=206946, BuffID = 506176},
		{ MountName="Pegasus Mount (Permanent, Swim)", ID=206283, BuffID = 505066},
		{ MountName="Black Pegasus Mount (Permanent, Swim)", ID=206289, BuffID = 505065},
		{ MountName="Purple Crested Ostrich Mount (Permanent)", ID=206316, BuffID = 505075},
		};
	for i, v in pairs(mounts_table) do
		if player:hasBuff(v.BuffID) then
			RoMScript("igf_CancelBuff("..v.BuffID..");")
			-- yrest(300);
			repeat
				yrest(100);
				self:update();
			until self.Mounted == false
			return;
		end
	end
end

What still can be usefull is the CancelBuff ingame function:

Code: Select all

function igf_CancelBuff(buffNameOrId)
  local i=0;
  repeat
    i=i+1
    local buff,icon,cnt,id,params = UnitBuff("player", i);
      -- ChatFrame1:AddMessage("buff:"..buff.." id:"..id);
      if type(buffNameOrId) == "number" then
        if( id == buffNameOrId ) then
          ChatFrame1:AddMessage("igf_CancelBuff("..buff..")");
          CancelPlayerBuff(i);
          return;
        end
      else
        if( buff == buffNameOrId ) then
          ChatFrame1:AddMessage("igf_CancelBuff("..buff..")");
          CancelPlayerBuff(i);
          return;
        end
      end
  until (buff==nil);
end

[rock5]

What I did was just make it mount again to dismount. That way it uses the same list of mounts and doesn't require a whole new function. All I did was modify mount to accept an argument to dismount

Code: Select all

player:mount(true)

This will dismount instead of mount. Then I added a simple dismount function to call that.

Code: Select all

function CPlayer:dismount()
	self:mount(true)
end

Much simpler and easier to maintain.