--=== Official new patch thread ===-- patch 4.0.9

[Edamh]

Couple of missing/extra parentheses but I went ahead and added/removed them accordingly.

Code: Select all

6:46am - scripts\rom/bot.lua:604: ')' expected near 'then'

Code: Select all

6:46am - scripts\rom/bot.lua:608: 'then' expected near ')'

Here are some of the output/debug messages. Again, the bot stopped attacking the main mob mid-battle and went to attack another mob instead.

Code: Select all

Fight finished. Killed 11 MOB_NAME_HERE. (fight #11 / runtime 7 minutes)
Clearing target.
Resting for 4 seconds.
Resting finished after 4 seconds.
Clearing target.
[DEBUG] FightStartX -954.00732421875 FightStartZ -2667.8962402344
[DEBUG] dir_FS->WP rad 1.827 dir_FS->FE rad 2.229
[DEBUG] Line FS->WP / FS->FE: angleDif rad 0.402 grad 23
[DEBUG] We (would) pass(ed) wp #3 (dist 158.0) in a dist of 63 (skip at 100)
Moving to waypoint #3, (-994, -2515)
Resting up to 23 to fill up mana and HP.
Resting finished after 1 seconds.
Moving to waypoint #4, (-816, -2522)
Stopping waypoint: Target acquired.
Engaging enemy [MOB_NAME_HERE] in combat.
We begin the fight with ranged pulling.
Ranged pulling finished, mob in melee distance.
Too close. Backing up.
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (1961/1961)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (1961/1961)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (1961/1961)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (1961/1961)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (1955/1961)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (1955/1961)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (1908/1961)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (1847/1961)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (1841/1961)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (1774/1961)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (1727/1961)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (1666/1961)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (1666/1961)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (1666/1961)
[DEBUG] 1040141056 anti kill steal: target not fighting us: target don't targeti
ng a friend
Fight finished. Killed 12 MOB_NAME_HERE. (fight #12 / runtime 8 minutes)
Clearing target.
[DEBUG] 0 target dist > MAX_TARGET_DIST with battling from other mob
[DEBUG] FightStartX -877.00634765625 FightStartZ -2497.3603515625
[DEBUG] dir_FS->WP rad -0.384 dir_FS->FE rad 0.315
[DEBUG] Line FS->WP / FS->FE: angleDif rad 0.699 grad 40
[DEBUG] We (would) pass(ed) wp #4 (dist 65.8) in a dist of 45 (skip at 100)
Moving to waypoint #4, (-816, -2522)
Moving to waypoint #5, (-808, -2671)
Moving to waypoint #6, (-798, -2867)
Moving to waypoint #1, (-1030, -3024)
Moving to waypoint #2, (-970, -2843)
[DEBUG] 663109888 target dist > MAX_TARGET_DIST with battling from other mob
We have aggro. Stop moving to waypoint and wait for target.
Engaging enemy [MOB_NAME_HERE] in combat.
Use MACRO: WARRIOR_PROBING_ATTA=>   MOB_NAME_HERE (1822/1961)

Now we are getting somewhere =)

Ok the code in question is this

Code: Select all

					if( settings.profile.options.ANTI_KS ) then
						if( target:haveTarget() and
							target:getTarget().Address ~= player.Address and
							 (not player:isFriend(CPawn(target.TargetPtr))) and
							target:getTarget().Address ~= 0 -- because of distance limitation
							and target:getTarget().InParty ~= true )then
								cprintf(cli.red, language[5], target.Name);
						else
							player:fight();
						end

					else
							player:fight();
					end

So in order for it to do the anti KS and stop killing mob it has to be true for all of these

mob isn't targeting you
target:getTarget().Address ~= player.Address

mob isn't targeting a "friend"
(not player:isFriend(CPawn(target.TargetPtr))

mob actually has a target
target:getTarget().Address ~= 0

mob isn't targeting a party member
target:getTarget().InParty ~= true


I am going to add some "debugging" prints to the attached file to narrow down which is causing it to trigger the anti-ks so we can then work out why.

Please test it and post what MM prints when it changes target.

[i_like_big_bots]

hey guys, how are you?

hey lisa, any new ideas about the spcial charakters problem from partyhealer?

[lisa]

Excellent, none of the prints I added actually printed, so that means the issue isn't with what I added lol

I think It's time to test the inparty bit, everything points to that not being correct.

[lisa]

Inparty indicator works perfectly, might have found the issue though, there is an anti-ks check which doesn't actually do the check for in party, seems I missed one of the many anti ks checks when I added party usage.

try this for me.

[Edamh]

Using latest player.lua. Here are outputs/messages. Main bot still left in middle of battle to attack another mob.

Code: Select all

Moving to waypoint #9, (525, -807)
Stopping waypoint: Target acquired before moving.
Engaging enemy [MOB_NAME_HERE] in combat.
We begin the fight with ranged pulling.
Use MACRO: WARRIOR_SURPRISE_ATT=>   MOB_NAME_HERE (3228/3228)
Ranged pulling finished, mob in melee distance.
Use MACRO: WARRIOR_TACTICAL_ATT=>   MOB_NAME_HERE (2944/3228)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (2816/3228)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (2816/3228)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (2755/3228)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (2516/3228)
Use MACRO: WARRIOR_SLASH       =>   MOB_NAME_HERE (2516/3228)
Use MACRO: WARRIOR_PROBING_ATTA=>   MOB_NAME_HERE (2260/3228)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (1859/3228)
Use MACRO: WARRIOR_PROBING_ATTA=>   MOB_NAME_HERE (1553/3228)
Use MACRO: WARRIOR_TACTICAL_ATT=>   MOB_NAME_HERE (1211/3228)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (1143/3228)
Use MACRO: WARRIOR_SLASH       =>   MOB_NAME_HERE (1143/3228)
Use MACRO: WARRIOR_PROBING_ATTA=>   MOB_NAME_HERE (1031/3228)
Use MACRO: WARRIOR_TACTICAL_ATT=>   MOB_NAME_HERE (479/3228)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (243/3228)
Use MACRO: WARRIOR_PROBING_ATTA=>   MOB_NAME_HERE (0/3228)
Fight finished. Killed 5 MOB_NAME_HERE. (fight #5 / runtime 7 minute
s)
Resting for 4 seconds.
Resting finished after 4 seconds.
Clearing target.
[DEBUG] FightStartX 574.73815917969 FightStartZ -1056.5941162109
[DEBUG] dir_FS->WP rad 1.767 dir_FS->FE rad -1.113
[DEBUG] Line FS->WP / FS->FE: angleDif rad 2.880 grad 165
[DEBUG] We (would) pass(ed) wp #9 (dist 254.5) in a dist of 504 (skip at 100)
Moving to waypoint #9, (525, -807)
Stopping waypoint: Target acquired.
Engaging enemy [MOB_NAME_HERE] in combat.
We begin the fight with ranged pulling.
Use MACRO: WARRIOR_SURPRISE_ATT=>   MOB_NAME_HERE (3373/3373)
Ranged pulling finished, mob in melee distance.
Use MACRO: WARRIOR_PROBING_ATTA=>   MOB_NAME_HERE (3226/3373)
Use MACRO: WARRIOR_TACTICAL_ATT=>   MOB_NAME_HERE (3226/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (3226/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (3226/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (3226/3373)
Use MACRO: WARRIOR_TACTICAL_ATT=>   MOB_NAME_HERE (3226/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (3167/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (3108/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (3108/3373)
Use MACRO: WARRIOR_SLASH       =>   MOB_NAME_HERE (2902/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (2810/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (2810/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (2720/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (2720/3373)
[DEBUG] 607483904 anti kill steal: target not fighting us: target don't targetin
g a friend or party member 2
Fight finished. Killed 6 MOB_NAME_HERE. (fight #6 / runtime 8 minute
s)
Clearing target.
[DEBUG] 0 target dist > MAX_TARGET_DIST with battling from other mob
[DEBUG] FightStartX 521.87915039063 FightStartZ -795.15191650391
[DEBUG] dir_FS->WP rad -1.313 dir_FS->FE rad 2.695
[DEBUG] Line FS->WP / FS->FE: angleDif rad 2.275 grad 130
[DEBUG] We (would) pass(ed) wp #9 (dist 12.3) in a dist of 22 (skip at 100)
[DEBUG] currentWp #9 525 -807, FE->WP rad -0.539
[DEBUG] nextWp #10 284 -753, FE->WP rad 3.127
[DEBUG] FE->wp#10 to FE->wp#9 is in a angle of 149 grad (skip at 90)
[DEBUG] We overrun waypoint #9, skip it and move on to #10
We overrun waypoint #9, skip it and move on to #10
Moving to waypoint #10, (284, -753)
Moving to waypoint #11, (168, -836)
Moving to waypoint #12, (-135, -835)
Durability:99.982142857143
Moving to waypoint #1, (-161, -852)

I'm taking a guess, and I think what's happening is my assist bot is a warden with a pet. When the warden pet attacks and takes aggro, the main bot stops attacking ... because the warden pet is not considered part of party?

[lisa]

'm taking a guess, and I think what's happening is my assist bot is a warden with a pet. When the warden pet attacks and takes aggro, the main bot stops attacking ... because the warden pet is not considered part of party?

That would explain it, I think also because your main character isn't doing enough damage to keep agro off the pet aswell, most of your attacks arn't doing damage.

Code: Select all

Use MACRO: WARRIOR_PROBING_ATTA=>   MOB_NAME_HERE (3226/3373)
Use MACRO: WARRIOR_TACTICAL_ATT=>   MOB_NAME_HERE (3226/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (3226/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (3226/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (3226/3373)
Use MACRO: WARRIOR_TACTICAL_ATT=>   MOB_NAME_HERE (3226/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (3167/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (3108/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (3108/3373)
Use MACRO: WARRIOR_SLASH       =>   MOB_NAME_HERE (2902/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (2810/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (2810/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (2720/3373)
Use MACRO: WARRIOR_OPEN_FLANK  =>   MOB_NAME_HERE (2720/3373)

Not sure if there is a way to tell if mob is targeting pet of a party member, I think you might be the only person even facing the issue.
I'll have a think on it, it would be easy to test, just make the second char not summon warden pet and see if it still occurs.

[i_like_big_bots]

Hey lisa only want to know.. do you have no ideas so far?

greetz

[lisa]

Hey lisa only want to know.. do you have no ideas so far?

greetz

I think the issue is I tested with an ascii character but you use a different language character, so chances are it works fine with ascii but not characters from other languages.

So at this stage I have no idea how to fix that.