SolarStrike Software

beanybabe wrote:i ran into a but that i think needs changed.


This waypoint demonstrates it. if you run it you char will start running to 0 0 0 I think it needs to be changed that it runs to the location were you currently are at. This would prevent characters running off and getting stuck some where. I know this if not a likely bit of code but it can happen if you are testing new waypoints.

Code: Select all

<?xml version="1.0" encoding="utf-8"?><waypoints type="TRAVEL">
<onLoad>
print ("help i am running to impossible location")

 </onLoad>
 <waypoint>
 
 </waypoint>
</waypoints>

BlubBlab wrote:I would say this should give a error message and not do anything,

		if( not self.X ) then self.X = 0.0; end;
		if( not self.Z ) then self.Z = 0.0; end;

lisa wrote:

BlubBlab wrote:I would say this should give a error message and not do anything,

Except some WP don't have any waypoints at all, like the AT or commandline scripts where everything is dealt with inside the onload, so if having no waypoints made the WP error then those scripts would no longer work.

Do I agree that running off into the distance to try to get to 0,0,0 is not good, for sure.

Q. Would someone creating a WP using createpath make a WP with no waypoints?
A. Very unlikely.

So this issue is only an issue with people who create WP manually by typing in the code, they should understand how the coding currently works.

In waypoint.lua it has the CWaypoint class, if there are no X or Z cords in the information given to the class it sets the values to 0.

Code: Select all

		if( not self.X ) then self.X = 0.0; end;
		if( not self.Z ) then self.Z = 0.0; end;

Maybe you could try playing around with this code and seeing if you can improve it, test the changes and report how the changes worked and what didn't work.

		if( not self.X ) then self.X = player.X; end;
		if( not self.Z ) then self.Z = player.Z; end;

		if( not self.X ) then error("some message") end;
		if( not self.Z ) then error("some message") end;

lisa wrote:Except some WP don't have any waypoints at all, like the AT or commandline scripts where everything is dealt with inside the onload, so if having no waypoints made the WP error then those scripts would no longer work.

rock5 wrote:There is no real need to support faulty waypoint like that but it would be extremely easy to add a check before adding the waypoint. Something along the lines of "if x and z then add the waypoint". That should avoid empty waypoints from being added and should solve the OPs original query.

Celesteria wrote:

rock5 wrote:There is no real need to support faulty waypoint like that but it would be extremely easy to add a check before adding the waypoint. Something along the lines of "if x and z then add the waypoint". That should avoid empty waypoints from being added and should solve the OPs original query.

the definition of "faulty waypoint" is relative. an empty waypoint is not a faulty waypoint if you want to use the bot as it is supposed to do (in my understanding). the event-section (onload) is to set variables, define functions and check start properties of the script. the waypoint-section is to handle the bot using the functions defined above. i know, everybody uses the onload-section if there is no need of waypoints, but this is a workaround, not the correct way. from this point of view it should be the correct way to add an empty waypoint to the __WPL as the current location and not to avoid them from being added. this makes the bot perfect and makes sense to everyone who understand a "real programing style"