Page 1 of 1
Party.lua
Posted: Mon Jul 25, 2011 10:32 pm
by Bojer
Ok I seem to have hit a snag here. Trying to finally party my priest with my rogue to heal but when I load rom\bot path:partyhealer it loads and all I get is
Party member has a name of Nibbs
No information for party 2
No information for party 3
No information for party 4
No information for party 5
That scrolls for awhile then crashes out. What am I doing wrong here?
Re: Party.lua
Posted: Mon Jul 25, 2011 11:15 pm
by lisa
Actually that is my fault, I didnt mean to upload my party.lua when I did last commit. Had it ticked by accident.
Update to rev 622 and it should be fine =)
Re: Party.lua
Posted: Tue Jul 26, 2011 12:00 am
by Bojer
Works now ....kinda.
My priest will now buff himself and the other party member but now will keep alternating between targeting himself and my Scout Party member......is this supposed to happen? Nor is he actually healing the scout.
Re: Party.lua
Posted: Tue Jul 26, 2011 12:58 am
by lisa
Yeah for now the healer will just follow round and target each party member and itself to see if they need healing or buffing.
When I get the time I am going to change that to get the hp and buffs from memory.
It should be using heals though, you need to have your profile set up with the skills though and have the hpper set to when you want it to heal. I set them kinda high for party bot in my profiles.
for priest I do this
Code: Select all
<skill name="PRIEST_URGENT_HEAL" hotkey="MACRO" priority="100" hpper="80" />
<skill name="PRIEST_REGENERATE" hotkey="MACRO" priority="90" hpper="90" />
<skill name="PRIEST_SOUL_SOURCE" hotkey="MACRO" priority="110" inbattle="true" hpper="30" />
<skill name="PRIEST_AMPLIFIED_ATTACK" hotkey="MACRO" priority="20" rebuffcut="60" inbattle="false" />
<skill name="PRIEST_GRACE_OF_LIFE" hotkey="MACRO" priority="20" rebuffcut="60" inbattle="false" />
<skill name="PRIEST_HEALING_SALVE" hotkey="MACRO" priority="95" />
Re: Party.lua
Posted: Tue Jul 26, 2011 9:55 am
by Bojer
This is my Priest skill setup which works solo.....
Code: Select all
<skills_priest>
<skill name="PRIEST_RISING_TIDE" modifier="" hotkey="VK_1" priority="70" />
<skill name="MAGE_LIGHTNING" modifier="" hotkey="VK_2" priority="104" />
<skill name="PRIEST_REGENERATE" modifier="" hotkey="VK_6" priority="102" hpper="80" />
<skill name="PRIEST_HEAL" modifier="" hotkey="VK_7" priority="108" hpper="20" />
<skill name="PRIEST_HOLY_AURA" modifier="" hotkey="VK_8" priority="110" inbattle="true" hpper="20" />
<skill name="PRIEST_SOUL_SOURCE" modifier="" hotkey="VK_9" priority="108" inbattle="true" hpper="10" />
<skill name="PRIEST_MAGIC_BARRIER" modifier="VK_CONTROL" hotkey="VK_1" priority="20" rebuffcut="60" inbattle="false" />
<skill name="PRIEST_BLESSED_SPRING_WATER" modifier="VK_CONTROL" hotkey="VK_2" priority="20" rebuffcut="60" inbattle="false" />
<skill name="MAGE_FIRE_WARD" modifier="VK_CONTROL" hotkey="VK_3" priority="20" rebuffcut="60" inbattle="false" />
<skill name="PRIEST_ANGELS_BLESSING" modifier="VK_CONTROL" hotkey="VK_4" priority="20" rebuffcut="60" inbattle="false" />
<skill name="PRIEST_ANGELS_CAROL" modifier="VK_CONTROL" hotkey="VK_5" priority="106" />
<skill name="PRIEST_GRACE_OF_LIFE" modifier="VK_CONTROL" hotkey="VK_6" priority="20" rebuffcut="60" inbattle="false" />
<skill name="PRIEST_SOUL_BOND" modifier="VK_CONTROL" hotkey="VK_7" priority="20" inbattle="false" />
</skills_priest>
Now what I see different is that you have hotkey="MACRO" while I have VK keys do I need to switch those to Macro? Also Soul Bond ...my priest keeps trying to cast that on my Scout even though he already cast it on himself and there is a 30 min cooldown.
Re: Party.lua
Posted: Tue Jul 26, 2011 10:04 am
by rock5
You don't have to change them to "macro" but it does free up your action keys. It used to be that "macro" was only available to some users but now anyone from any language can use it so it was changed.
Re: Party.lua
Posted: Tue Jul 26, 2011 10:45 am
by lisa
Bojer wrote: Also Soul Bond ...my priest keeps trying to cast that on my Scout even though he already cast it on himself and there is a 30 min cooldown.
There is no cooldown added to the skills database, not sure why not.
You could try just adding in the cooldown and see how it goes.
Re: Party.lua
Posted: Tue Jul 26, 2011 11:18 am
by rock5
The skill doesn't need a cooldown because it's a buff with a long duration. It's supposed to detect the buff on yourself and not try to cast it again until the buff expires. If it's repeatedly casting it then it is not detecting the buff.
I can think of a number of reasons for this.
1. You don't have the buff but you say you do.
1. The buff id is wrong but it looks like it's correct.
2. It's not looking on himself for the buff, although it shouldn't do that.
Re: Party.lua
Posted: Tue Jul 26, 2011 11:22 am
by lisa
3. you have the buff but the bot is trying to cast it on a party member who doesn't have the buff
Re: Party.lua
Posted: Tue Jul 26, 2011 11:45 am
by rock5
lisa wrote:3. you have the buff but the bot is trying to cast it on a party member who doesn't have the buff
I was thinking something along those lines but it still shouldn't act that way. If it's checking a party member for a buff and then casts it on him then it should stop casting. If it's checking itself then it should cast it and then stop. So if it's trying to cast it on a party member and keeps casting it then that would mean it doesn't have the party member targeted. So maybe it's a targeting issue.
Or maybe the target can't recieve the buff? Maybe like a npc or pet.
Re: Party.lua
Posted: Tue Jul 26, 2011 5:59 pm
by Bojer
rock5 wrote:lisa wrote:3. you have the buff but the bot is trying to cast it on a party member who doesn't have the buff
I was thinking something along those lines but it still shouldn't act that way. If it's checking a party member for a buff and then casts it on him then it should stop casting. If it's checking itself then it should cast it and then stop. So if it's trying to cast it on a party member and keeps casting it then that would mean it doesn't have the party member targeted. So maybe it's a targeting issue.
Or maybe the target can't recieve the buff? Maybe like a npc or pet.
Well it can be cast on other person but it has a 30 min recast timer. So once it casts it on my priest it cant cast is for another 30 mins but it is targeting my Scout trying to cast it on them but as it is on cooldown it fails and just keeps trying over and over.
After reading various posts on here would something like this work???
Code: Select all
<skill name="PRIEST_SOUL_BOND" modifier="VK_CONTROL" hotkey="VK_7" priority="20" reqbufftype="buff" reqbufftarget="player" reqbuffname="SOUL_BOND" inbattle="false" />
Re: Party.lua
Posted: Wed Jul 27, 2011 2:31 am
by rock5
Bojer wrote:Well it can be cast on other person but it has a 30 min recast timer. So once it casts it on my priest it cant cast is for another 30 mins but it is targeting my Scout trying to cast it on them but as it is on cooldown it fails and just keeps trying over and over.
Actually that's a very good point and may just be the problem. It would mean we would have to add cooldown values to all friendly buffs for just this reason. Grrr...
Bojer wrote:would something like this work???
Code: Select all
<skill name="PRIEST_SOUL_BOND" modifier="VK_CONTROL" hotkey="VK_7" priority="20" reqbufftype="buff" reqbufftarget="player" reqbuffname="SOUL_BOND" inbattle="false" />[/
quote]It might but I'm not a party player so I'm not sure. Probably Lisa would know.
Re: Party.lua
Posted: Wed Jul 27, 2011 2:45 am
by lisa
reqbuffname="SOUL_BOND"
No because you are saying you need to have the buff before casting the buff, which isn't what you want at all.
Just add in a cooldown to the existing skill in database and it should be fine. I think though for this specific skill it should be cast on the player only and not other party members. Assuming you have your healer set up to also resurect party members.
Re: Party.lua
Posted: Wed Jul 27, 2011 2:54 am
by rock5
I just saw "player" and thought thats only what he changed. Would changing just targert="player" work?
Re: Party.lua
Posted: Wed Jul 27, 2011 3:14 am
by lisa
rock5 wrote:I just saw "player" and thought thats only what he changed. Would changing just targert="player" work?
I think it would need to be
target="self"