Page 1 of 1

Custom skill not casting right

Posted: Mon Apr 25, 2011 11:49 pm
by MiesterMan
Custom skill - Item-Skill Set "Spirit Herb Essence":

Code: Select all

<skill name="ITEMSET_SPIRIT_HERB_ESSENCE" aslevel="55" cooldown="8" type="heal" target="self" casttime="3" inbattle="false"/>
I increased the cast time from 2 to 3 hoping it would help but it didn't. The skill will cast fine when in rest mode but between fights it will start to cast then run in the middle of casting, cancelling the cast.

I can't figure out what the problem is. If you can see something please let me know.

Edit -
This is how I use it in profile:

Code: Select all

<skill name="ITEMSET_SPIRIT_HERB_ESSENCE"	hotkey="VK_N" priority="94" hpper="( (player.MaxHP - 2500) / player.MaxHP)"/>

Re: Custom skill not casting right

Posted: Wed Apr 27, 2011 3:05 am
by Administrator
Try just setting the cast time higher.

Re: Custom skill not casting right

Posted: Wed Apr 27, 2011 9:07 pm
by lisa
I think the issue here is an old one, the bot doesn't wait for casts to complete, You can really notice it when it tries to use a long heal while out of combat, it starts the cast and then moves. Generally if you are in combat the bot isn't moving and all casts seem to work fine.
I haven't spent any time looking into it as yet but yeah it's been like this for as long as I've been using the bot.

Re: Custom skill not casting right

Posted: Fri Apr 29, 2011 6:11 pm
by MiesterMan
Administrator wrote:Try just setting the cast time higher.
Increased cast time to 10 seconds, same behavior.
lisa wrote:I think the issue here is an old one, the bot doesn't wait for casts to complete, You can really notice it when it tries to use a long heal while out of combat, it starts the cast and then moves. Generally if you are in combat the bot isn't moving and all casts seem to work fine.
I haven't spent any time looking into it as yet but yeah it's been like this for as long as I've been using the bot.
Omg, I didn't notice it was like that. I suppose since the only heals I ever really used were urgent heal in my m/p since it's infinite healing for next to nothing mana and r/k elite Power of the Lion which for some reason isn't working right now. I dunno what happened, before I quit playing for two months it was working fine. Anyways, ty for letting me know I'm not crazy, it helps. :lol:

Re: Custom skill not casting right

Posted: Fri Apr 29, 2011 7:44 pm
by rock5
When casting skills it tries to start casting the next one before it finishes for faster casting. That is by design. But I guess it's possible that if it is casting a timed spell and no skill follows it, it might move before it finishes. I think we could put a check in, "if out of combat then wait till casting ends". I'll look into it.

Re: Custom skill not casting right

Posted: Fri Apr 29, 2011 8:08 pm
by rock5
I've committed a fix in rev 602. I've been able to test it so it works. I'm pretty sure it shouldn't interfer with normal combat casting.