SolarStrike Software

checkii wrote:

WhiteTiger wrote:instead of looting the nearby corpses, it targeted a new mob and started attack him (it was after I had left combat). then when he was dead the bot returned and looted the mob.

I had another post describing this situation however the bot doesn't always loot the mobs. So you loot some of the time, but not always.

The reason I ask if you use AOE was because the problem i experience, specifically applies to AOE spells/skill where your bot will sometimes skip lootable bodies and move on to the next target. As of right now I still don't have a solution to that. My current fix is to just stay with single target spells. It seems lootbodies() will always (for the most part) loot if your bot uses single target spells.

Ofcourse its not very ideal, since AoE is faster. If anyone has figure out a way for loot to work with AOE, please share
I believe it has something to do with where i stick lootbodies(), which may be as simple as putting a delay. I don't mind redundancy, any workable solution will be appreciated.

checkii wrote:Can we commit the above changes to the script? See how it works out?

The attack sequence I am using is mage purgatory fire range 50 (I edited skill.xml to reflect the 50 range).

To make the skill cast faster, onskillcast I would tell it to cast purgatory again. Although without onskillcast the bot still has same looting pattern (of missing loot sometimes).

I can take a wild guess that when I cast purgatory I may kill mobs that were not on my aggro list because they died too fast. Or they are on their way to me while I was in combat, but died before reaching me because of AE. Basically the bot did not pick up multiple aggro and therefore ignores the loot. This is also why single target spells do not have loot issues as the bot picked up each individual aggro, and thereby looting them individually.

On a side note, not sure if this is relevant. It seems that every time I overran a waypoint, looting will be ignored and he continues on his way. I dont know if that takes priority over looting.

i would love to have a script that loots indiscriminately even if the loot belongs to someone else. Though in this case, I did kill it.

WhiteTiger wrote:Hmm, is there any way I can make the bot loot faster? e.g. make so he doesn't have to wait for the corpse to disapear before moving to the next?

rock5 wrote:Which code are you talking about? The one from miximixi007? He doesn't say what it's supposed to do, what he's changed and it looks like he based it on an older version of rombot.

It doesn't wait for the corpse to disappear. The time it waits is a calculated time. I guess we could speed it up a tiny bit by having it stop waiting once the body is no longer lootable. I'll look into it.

Edit: changed revision 515 to stop waiting when the body is no longer lootable. Saves a tiny amount of time.

checkii wrote:To make the skill cast faster, onskillcast I would tell it to cast purgatory again.

Administrator wrote: I wouldn't have a problem with that, except for one thing: already looted corpses become a problem. If you've looted a corpse but use a loot filter or don't have space in your inventory for some items, the body stays on the ground and lootable for some time. This would cause the bot to continue to and loot it over and over again. One solution to this is holding a table of recently looted corpses, but this is far from a decent solution. Some corpses (such as bosses) last for a long time. However, using a long timer on removing a corpse from this list could cause the bot to not want to loot some fresh corpses that happen to have the same ID of corpses that have already disappeared.

miximixi007 wrote:

checkii wrote:To make the skill cast faster, onskillcast I would tell it to cast purgatory again.

How to do this?

		-- Additional Lua code to execute when casting a skill
		-- Note: arg1 contains the skill being used.
		-- i.e. arg1.Name will be the name of the skill being cast
		-- e.g.:
		--if( 15 > player.HP/player.MaxHP*100 ) then
		--    player:cast("PRIEST_SOUL_SOURCE");
		--elseif( 25 > player.HP/player.MaxHP*100 ) then
		--    player:cast("PRIEST_HOLY_AURA");
		--    player:cast("PRIEST_URGENT_HEAL");
		--    player:cast("PRIEST_URGENT_HEAL");

Petzzz wrote:after 2-3h of testing i found a bug. we need a skip loot and return to waypoint after 5 sec not moving/looting (sometimes bot didnt loot all mobs and get stucked by trying to loot mobs out of range or behind walls).

Petzzz wrote:request was not to skip a single corps. i mean skip the howl looting after 5 sec not moving/looting. why not add a timer after last try to loot and last loot done.
so if timer > 5 sec skip looting (so we cant get stucked by trying to loot the dead boddy again and again because the lootbodies will not be called again untill we killed the next mob) with lootbodies at onleavecombat.