Page 8 of 12

Re: Eggs

Posted: Wed Jul 14, 2010 9:09 am
by rock5
DrG wrote:With the rev 472 we still can double pick the eggs?
Yes, it should make no difference.

Re: Eggs

Posted: Wed Jul 14, 2010 2:46 pm
by qcalex
rock5 wrote: Insert at line 95 of player.lua, just before "self:update();" the following;

Code: Select all

		if _id then -- The rest is not needed if not resource node
			lastHarvestedNodeAddr = closestHarvestable.Address;
			return true
		end
This way it will skip the harvest checks which interrupt you.
does we still need to apply this change? or not anymore? just to be sure

Re: Eggs

Posted: Wed Jul 14, 2010 10:36 pm
by rock5
qcalex wrote:
rock5 wrote: Insert at line 95 of player.lua, just before "self:update();" the following;

Code: Select all

		if _id then -- The rest is not needed if not resource node
			lastHarvestedNodeAddr = closestHarvestable.Address;
			return true
		end
This way it will skip the harvest checks which interrupt you.
does we still need to apply this change? or not anymore? just to be sure
This is only needed if you intend to still use 'harvest' to collect objects. You should be using 'target_Object' instead.

Either way it doesn't matter as it has already been added to the most recent SVN revisions.

Re: Eggs

Posted: Thu Jul 15, 2010 4:09 pm
by qcalex
Just to do a recap.

you Need to have rombot Version 472

Re: Eggs

Posted: Thu Jul 15, 2010 4:40 pm
by Starrider
is there still a solution for the "nil" value crash?
The error occures when the bot stand at WP1 and after the bot did feed 3 chickens.

Re: Eggs

Posted: Thu Jul 15, 2010 5:50 pm
by rock5
Starrider wrote:is there still a solution for the "nil" value crash?
The error occures when the bot stand at WP1 and after the bot did feed 3 chickens.
The milk and egg scripts have checks to avoid it so any 'nil' error is most likely from the known issue with RoMScript. It shouldn't happen very often. Hopefully 1 day Administrator will find a way to fix it.

Re: Eggs

Posted: Thu Jul 15, 2010 6:39 pm
by raffe
Hi got thys error while trying to run the script right after it loads


Code: Select all

[string "..."]:2: attempt to call global 'getQuestStatus' (a nil value)
any ide how to fix it ?

Re: Eggs

Posted: Thu Jul 15, 2010 6:44 pm
by rock5
raffe wrote:Hi got thys error while trying to run the script right after it loads


Code: Select all

[string "..."]:2: attempt to call global 'getQuestStatus' (a nil value)
any ide how to fix it ?
Update to the latest SVN revision.

Re: Eggs

Posted: Fri Jul 16, 2010 4:47 am
by raffe
Update to the latest SVN revision.
Lol thx m8, works now perfectly ^^

Re: Eggs

Posted: Fri Jul 16, 2010 8:36 am
by Starrider
rock5 wrote:
Starrider wrote:is there still a solution for the "nil" value crash?
The error occures when the bot stand at WP1 and after the bot did feed 3 chickens.
The milk and egg scripts have checks to avoid it so any 'nil' error is most likely from the known issue with RoMScript. It shouldn't happen very often. Hopefully 1 day Administrator will find a way to fix it.
the error is actually forced by the eggs script, because I never had all the long time I used the bot an crash/error like this. Only since i use the eggs-WP i still got the nil value crash at WP 1 some times after 20, sometimes after 2h, but it only occures at millers farm...
But so long, thanks for the script!

Re: Eggs

Posted: Fri Jul 16, 2010 10:27 am
by rock5
Starrider wrote:the error is actually forced by the eggs script, because I never had all the long time I used the bot an crash/error like this. Only since i use the eggs-WP i still got the nil value crash at WP 1 some times after 20, sometimes after 2h, but it only occures at millers farm...
But so long, thanks for the script!
I think it's from getItemCount. It doesn't have any safeguards for the 'nil' error. itemTotalCount should be more reliable.

Try changing line 19;

Code: Select all

			if 1 > inventory:getItemCount(204789) then -- Get more feed
to

Code: Select all

			inventory:update()
			if 1 > inventory:itemTotalCount(204789) then -- Get more feed
I'm currently working on a solution to once and for all fix the 'nil' error. It will still take some more testing though.

Re: Eggs

Posted: Fri Jul 16, 2010 11:20 am
by Croustibat
Hi, first thank you rock5 for your script, works good!

My character collects Golden Eggs 1 by 1, i though it could collect them 2 by 2, like regular eggs, is it normal?
No crash for me (tested during ~ an hour)

Re: Eggs

Posted: Fri Jul 16, 2010 11:40 am
by rock5
Croustibat wrote:Hi, first thank you rock5 for your script, works good!

My character collects Golden Eggs 1 by 1, i though it could collect them 2 by 2, like regular eggs, is it normal?
No crash for me (tested during ~ an hour)
If you have the latest version it should, quite reliably, take 2 gold eggs at a time.

Re: Eggs

Posted: Fri Jul 16, 2010 12:01 pm
by Croustibat
I did manual update (all files are updated except skills_local.xml and adresses.lua) because when i uses SVN, it did nothing, files were not updated ... i dont understand why..

thanks anyway

Re: Eggs

Posted: Fri Jul 16, 2010 12:11 pm
by rock5
Croustibat wrote:I did manual update (all files are updated except skills_local.xml and adresses.lua) because when i uses SVN, it did nothing, files were not updated ... i dont understand why..

thanks anyway
No, I meant latest version of my eggs script. LoL. It should say version 1.1 at the top of the file if you open it.

Re: Eggs

Posted: Fri Jul 16, 2010 12:59 pm
by prograx
i got a question about the milk thing.
script worcs perfect for me, big thx.
just wondering, what you can get out of this farmpacks?
someone said he got an item for an extra petslot out of it, but i never found one.
can this items be found in the packs or was that just a joke?

Re: Eggs

Posted: Fri Jul 16, 2010 3:20 pm
by qcalex
got over 500of pack and nerver drop anything else the the meat milk cheese and the +10 loyauty thing

Re: Eggs

Posted: Fri Jul 16, 2010 4:14 pm
by thetestdummy
with rocks chicken script, sometimes it only picks 1 golden egg, but im sure this is probably just due to lag for me,

Re: Eggs

Posted: Fri Jul 16, 2010 9:54 pm
by rock5
thetestdummy wrote:with rocks chicken script, sometimes it only picks 1 golden egg, but im sure this is probably just due to lag for me,
Make sure you have the latest version 1.1 of my script. I improved the timing in that version to be more reliable.

It will still sometimes miss but it wont happen very often. If you are still getting a lot of misses, then probably it is due to lag, like you said.

Re: Eggs

Posted: Sat Jul 17, 2010 3:34 am
by somberland
Hmm looks like the Milk-Script won't work (for me?) it finds the goat, try's to feed it an break that feeding instant.