Version 7.4.0.2897 progress

Runes of Magic/Radiant Arcana (http://www.runesofmagic.com)
Locked
Message
Author
Axman
Posts: 9
Joined: Mon Dec 16, 2019 1:59 pm

Re: Version 7.4.0.2897 progress

#461 Post by Axman » Thu Apr 23, 2020 3:35 pm

Hi again
Aoe's runic overload ability of the Champion / rogue does not work, since it is only ignored in the skills list.
Other problem is with skill list long, no work all skill or solo work max 6 then repeat cycle. Have i have that problem with druid, champion and scouts.

Best regards

User avatar
Administrator
Site Admin
Posts: 5306
Joined: Sat Jan 05, 2008 4:21 pm

Re: Version 7.4.0.2897 progress

#462 Post by Administrator » Thu Apr 23, 2020 4:07 pm

Just pushed up yet another skill change; now it should attempt to use the skill out of the skill book rather than casting by name. This avoids the endless stream of issues with trying to handle language strings.
Aoe's runic overload ability of the Champion / rogue does not work, since it is only ignored in the skills list.
Are you saying that it does not show up on the "Found skill" list when starting the script?

saverombotplz
Posts: 27
Joined: Sat Dec 14, 2019 3:52 pm

Re: Version 7.4.0.2897 progress

#463 Post by saverombotplz » Thu Apr 23, 2020 4:41 pm

are minigames working now because i tried everything and didnt work for me? none of them did please help

morc
Posts: 75
Joined: Thu Jan 02, 2020 7:32 am

Re: Version 7.4.0.2897 progress

#464 Post by morc » Fri Apr 24, 2020 1:28 am

Administrator wrote: Thu Apr 23, 2020 2:31 pm I've pushed up a whole bunch of changes in the last 24 hours. This should address a number of issues with stability, items (including cards!), skills, and more.
I would ask you all to update if you haven't already and see whether or not your problems have been fully addressed.

The fix to skills I just pushed up may (and probably does) break skill usage for non-English clients; can anyone report what does and does not work?
Hi!

champion/mage skill use problem solved :) many thanks (bot use mage skills)

morc
Posts: 75
Joined: Thu Jan 02, 2020 7:32 am

Re: Version 7.4.0.2897 progress

#465 Post by morc » Fri Apr 24, 2020 6:32 am

The buff use is not good :(
use at startup but after never (no renewal)

User avatar
Administrator
Site Admin
Posts: 5306
Joined: Sat Jan 05, 2008 4:21 pm

Re: Version 7.4.0.2897 progress

#466 Post by Administrator » Fri Apr 24, 2020 8:36 am

morc wrote: Fri Apr 24, 2020 6:32 am The buff use is not good :(
use at startup but after never (no renewal)
Could you copy/paste the entry from your profile from me? I'm guessing you don't have anything unusual set, but might need your exact config for that skill to reproduce it.


In other news, I'm still fighting to figure out what's causing the random crashing and system instability. I'm confident that there's a buffer overflow somewhere, but it is not an easy thing to nail down; especially when it happens so randomly and can take ~45 minutes before each run til it shows up, and then things crash before you can extract any useful data...

Sasuke
Posts: 503
Joined: Mon May 17, 2010 3:40 pm
Location: Poland

Re: Version 7.4.0.2897 progress

#467 Post by Sasuke » Fri Apr 24, 2020 8:44 am

with the latest update I have a problem ... every time I start the bot in the choice of characters I always see 2 names for each and when I click on the arrow below to select a name I have a doubling of the strings.After selection the name bot not works cause ingame function need to be copy in addons folder....but there is it with aupdate
Attachments
bot.jpg

morc
Posts: 75
Joined: Thu Jan 02, 2020 7:32 am

Re: Version 7.4.0.2897 progress

#468 Post by morc » Fri Apr 24, 2020 9:07 am

Add prediction for block 626000, branch 0x190
Add prediction for block 200000, branch 0xEC
Last edited by morc on Sat Apr 25, 2020 1:43 am, edited 1 time in total.

Uniden65
Posts: 151
Joined: Thu Aug 20, 2009 5:17 pm

Re: Version 7.4.0.2897 progress

#469 Post by Uniden65 » Sat Apr 25, 2020 1:34 am

Doing a great job guys ... the LOOT_SIGILS still does not work .. if you turn it on bot will crash everytime...

morc
Posts: 75
Joined: Thu Jan 02, 2020 7:32 am

Re: Version 7.4.0.2897 progress

#470 Post by morc » Sat Apr 25, 2020 5:01 am

Administrator wrote: Fri Apr 24, 2020 8:36 am
morc wrote: Fri Apr 24, 2020 6:32 am The buff use is not good :(
use at startup but after never (no renewal)
Could you copy/paste the entry from your profile from me? I'm guessing you don't have anything unusual set, but might need your exact config for that skill to reproduce it.


In other news, I'm still fighting to figure out what's causing the random crashing and system instability. I'm confident that there's a buffer overflow somewhere, but it is not an easy thing to nail down; especially when it happens so randomly and can take ~45 minutes before each run til it shows up, and then things crash before you can extract any useful data...
<skills_knight>

<!--skill name="KNIGHT_HOLY_STRIKE" hotkey="MACRO" priority="90" -->
<skill name="KNIGHT_ENHANCED_ARMOR" hotkey="MACRO" priority="90" />
<skill name="KNIGHT_CHARGE" hotkey="MACRO" priority="92" />
<skill name="KNIGHT_LIGHT_ENERGY_WEAPON" hotkey="MACRO" priority="90" />
<skill name="MAGE_FIREBALL" hotkey="MACRO" priority="98" />


<!--skill name="MAGE_FIREBALL" modifier="" hotkey="VK_9" priority="96" cooldown=".3" -->
<!--skill name="MAGE_LIGHTNING" hotkey="VK_0" priority="94" -->

</skills_knight>

work with prev update (commit 53a5c544d3c81795790b917be57018951ab3060b)

User avatar
ThulsaDoom
Posts: 123
Joined: Mon Oct 19, 2015 2:46 pm

Re: Version 7.4.0.2897 progress

#471 Post by ThulsaDoom » Sat Apr 25, 2020 8:29 am

CDWriter wrote: Sat Apr 25, 2020 1:34 am Doing a great job guys ... the LOOT_SIGILS still does not work .. if you turn it on bot will crash everytime...
No problem with sigils. looting it correctly.

Skill needs double click like MAGE_THUNDERSTORM still broken.
Not priority, PET assist not working.

Thanks for your support!!

User avatar
Administrator
Site Admin
Posts: 5306
Joined: Sat Jan 05, 2008 4:21 pm

Re: Version 7.4.0.2897 progress

#472 Post by Administrator » Sat Apr 25, 2020 1:07 pm

I finally at least am on the right track as to what is causing the crashing. At least, in the high level. I still have a lot of little details to work out.

Basically, it's working something like this:
  • Some macro action needs to be performed
  • Find available macro address
  • Found address is sometimes (randomly) *wrong*, resulting in it pointing to the wrong memory space
  • Write macro name and body at said wrong location
  • Macro name is "RB", hex: 0x52 0x42 0x00, assembly: push edx, inc edx, add [eax],al
  • CPU (eventually) comes around to execute that function, hits malformed address and begins executing arbitrary code
  • Shit goes bananas; especially if the game is being run with escalated privileges, resulting in kernel calls that cause system instability
Attachments
romdebug.png

tristanlol
Posts: 16
Joined: Sun Dec 29, 2019 5:59 pm

Re: Version 7.4.0.2897 progress

#473 Post by tristanlol » Sat Apr 25, 2020 5:30 pm

Administrator wrote: Sat Apr 25, 2020 1:07 pm I finally at least am on the right track as to what is causing the crashing. At least, in the high level. I still have a lot of little details to work out.

Basically, it's working something like this:
  • Some macro action needs to be performed
  • Find available macro address
  • Found address is sometimes (randomly) *wrong*, resulting in it pointing to the wrong memory space
  • Write macro name and body at said wrong location
  • Macro name is "RB", hex: 0x52 0x42 0x00, assembly: push edx, inc edx, add [eax],al
  • CPU (eventually) comes around to execute that function, hits malformed address and begins executing arbitrary code
  • Shit goes bananas; especially if the game is being run with escalated privileges, resulting in kernel calls that cause system instability
Great news! In the last versions stability is the critical point of pain. Sometimes I had to reboot my computer after that kind of crashes.

Happy hunting and thanks!

User avatar
Administrator
Site Admin
Posts: 5306
Joined: Sat Jan 05, 2008 4:21 pm

Re: Version 7.4.0.2897 progress

#474 Post by Administrator » Sun Apr 26, 2020 1:17 pm

tristanlol wrote: Sat Apr 25, 2020 5:30 pm Great news! In the last versions stability is the critical point of pain. Sometimes I had to reboot my computer after that kind of crashes.

Happy hunting and thanks!
I've also tried looking through the change history and reverting some changes that I think could be related and seeing if that fixes the situation; no luck yet determining what is going on. Do you happen to know which commit, or at least approximately the date, where this started happening?

User avatar
ThulsaDoom
Posts: 123
Joined: Mon Oct 19, 2015 2:46 pm

Re: Version 7.4.0.2897 progress

#475 Post by ThulsaDoom » Sun Apr 26, 2020 2:01 pm

ThulsaDoom wrote: Tue Mar 31, 2020 11:09 am
Administrator wrote: Sun Mar 29, 2020 10:06 pm
CDWriter wrote: Sun Mar 29, 2020 7:47 pm So I take it the bot NO longer works …? Iam back to play again after yeats of being gone but I cant get the bot running with 7.4.0.2904

Help please from anyone …
Currently working for me. I just pushed up a commit to git earlier today.
Big thanks to Andre235 for providing tons of fixes!
Since last update, RoMBot crash with large number of accounts at same time.
Runs smoothly with two accounts, but with six, after few minutes the Runes window freezes, without any information in the MicroMacro window which remains with the last executed instruction.

I don't know if only happens to me.
Hello;
Instability started with last update done before 31/03.

Sasuke
Posts: 503
Joined: Mon May 17, 2010 3:40 pm
Location: Poland

Re: Version 7.4.0.2897 progress

#476 Post by Sasuke » Mon Apr 27, 2020 8:14 am

can i have explanation about why rom/createpath not works?is it normal now?

morc
Posts: 75
Joined: Thu Jan 02, 2020 7:32 am

Re: Version 7.4.0.2897 progress

#477 Post by morc » Mon Apr 27, 2020 11:07 am

Sasuke wrote: Mon Apr 27, 2020 8:14 am can i have explanation about why rom/createpath not works?is it normal now?
it works for me

Uniden65
Posts: 151
Joined: Thu Aug 20, 2009 5:17 pm

Re: Version 7.4.0.2897 progress

#478 Post by Uniden65 » Mon Apr 27, 2020 6:32 pm

with this updatei get

[DEBUG] CPU Frequency 10000
Wrong value returned in update of item id: 202940
The game client did not crash.
Character: Xxxxxxxxx
2020-04-27 18:31:41 - ...s/common/Runes of Magic/Bot/scripts/rom/classes/item.lua:143: attempt to concatenate field 'Name' (a nil value)

and bot will not start

after copying my profiles and waypoints, deleted everything unziped my old backup from 2 updates and redid the Update to current .... fix the issue.. I think the issue was in my profile ...

tristanlol
Posts: 16
Joined: Sun Dec 29, 2019 5:59 pm

Re: Version 7.4.0.2897 progress

#479 Post by tristanlol » Wed Apr 29, 2020 6:13 pm

Administrator wrote: Sun Apr 26, 2020 1:17 pm
tristanlol wrote: Sat Apr 25, 2020 5:30 pm Great news! In the last versions stability is the critical point of pain. Sometimes I had to reboot my computer after that kind of crashes.

Happy hunting and thanks!
I've also tried looking through the change history and reverting some changes that I think could be related and seeing if that fixes the situation; no luck yet determining what is going on. Do you happen to know which commit, or at least approximately the date, where this started happening?
It's hard to know... I pull from repository so frequently and I'm not using the scripts regularly to know which commit is responsible. On weekend I will investigate it more.

Thanks again!

User avatar
Administrator
Site Admin
Posts: 5306
Joined: Sat Jan 05, 2008 4:21 pm

Re: Version 7.4.0.2897 progress

#480 Post by Administrator » Wed Apr 29, 2020 7:16 pm

I'm still going through history and checking various commits, and also independently testing by feature. Still haven't pinned down the root cause, but at least that means I'm narrowing down what it isn't.
If you have the ability to test things out then I encourage you to do so, but also understand that it can be difficult to do so and I'm not going to expect anything.

Unrelated to that, I also have a handful of smaller commits that are improvements to the memory database stuff. It'll vastly improve the speed and accuracy of doing lookups. But if the game is still going to be crashing, then it doesn't serve much need, and I'm trying to not roll that kind of stuff out now to limit the number of changes I'll need to review.

Sorry there's not much of interest to report here. At the very least this should serve to let everyone know I'm still on the case.

Locked

Who is online

Users browsing this forum: Ahrefs [Bot] and 30 guests