Page 2 of 4
Re: BlubBlab's Lyliya
Posted: Mon Oct 07, 2013 7:59 am
by nerf
is a great job
Re: BlubBlab's Lyliya
Posted: Wed Oct 09, 2013 4:37 pm
by dr-nuker
It's not a real deal, but in my opinion it's not the best behavior to copy a script from others,
edit it and put only your Name on it without mentioning that you basically just edited a script someone else posted in another topic...
Re: BlubBlab's Lyliya
Posted: Wed Oct 09, 2013 7:14 pm
by rock5
dr-nuker wrote:It's not a real deal, but in my opinion it's not the best behavior to copy a script from others,
edit it and put only your Name on it without mentioning that you basically just edited a script someone else posted in another topic...
Copying is fine, it's all open source here and it's a good way to learn. But, yes, he should give credit where credit is due.
Re: BlubBlab's Lyliya
Posted: Thu Oct 10, 2013 3:33 am
by BlubBlab
I can and gave Credit for the base script and the idea of using swinmhack and teleport.
But I must point out that I nearly changed everything in the script except a few vars 2th loops and a functions prototype and I'm still not through.
Re: BlubBlab's Lyliya
Posted: Thu Oct 10, 2013 4:35 am
by dr-nuker
Anyways...
I just wanted to mention that it is nice to find so many waypoints here and that so many people contribute here!
It is also good to reuse code that is already existing, refine it and publish it, so that in the end everyone has some benefit of that.
But what I wanted to point out is that it is usually not good to take snippets from others, work stuff around them and forget to mention who else put effort in.
I don't mention this because I made the snippet this is based on, but it's the same with the AndorRange script. The routine used there is basically from Lisa and all the contributors in the topic where snippets for that minigame were tried out and discussed.
I guss Lisa does also not have any sort of problem with people using the code presented here, but in my eyes it endagers the principle of donating code here.
The only thing you get when releasing code is maybe someones happines by reading "Thanks" or increasing count of dowloads or even contribution by discussing possible improvements. This all disappears when separating the basic topic with all contributors and not mentioning that it is basically not your own code but someone else's that you improved and put your name on it.
I think it makes no further sense to discuss this since it would lead to far from what the topic is about.
Re: BlubBlab's Lyliya
Posted: Thu Oct 10, 2013 5:52 am
by BlubBlab
It's not the point I forgot completely that I'm using someone others script or wanted to ignore it.
I'm simple always in a hurry making the code more reliable so I spent over a week 2-3 hours for both script peer day, on top of that both a linked in the discuss thread from the topic, so I forgot to mention and giving credits at the end.
I gave lisa also credit at the point you mention it.
Re: BlubBlab's Lyliya
Posted: Fri Oct 11, 2013 1:39 pm
by wilifox
Good job
.
BlubBlad only english client?? Thx you
Re: BlubBlab's Lyliya
Posted: Sat Oct 12, 2013 12:54 am
by BlubBlab
Their are only 2 lines language specific(which works for most western languages). I will upload a new version soon.
Edit: DONE
Re: BlubBlab's Lyliya
Posted: Tue Oct 15, 2013 5:29 am
by krogan
Thanks for sharing your work.
Did anyone know what the pearls for?You get them when you talk to lyliya after you play the game.
Re: BlubBlab's Lyliya
Posted: Thu Oct 17, 2013 7:51 am
by lolita
it sometimes fail to finish game, it teleport to all items, but dont cast spell on them, i dont know why.
And i added Round counter to your mainrutine function
Code: Select all
local function mainroutine()
count = 0
while true do
count = count + 1
cprintf(cli.yellow,"Round "..count.."\n")
yrest(4500)
cprintf(cli.lightblue,"Memorize room \n")
...
Re: BlubBlab's Lyliya
Posted: Thu Oct 17, 2013 10:07 am
by BlubBlab
Which version?
I can only tell you sometimes with my bigger char I've got a miss the problem is the char got pulled back, because something was in the way ,but only happens 1 time in average in a game.
On cast I (count 3 failed cast or 5 tries at all ) or (success)and then stop and go to the next object.
Re: BlubBlab's Lyliya
Posted: Thu Oct 17, 2013 5:26 pm
by lolita
Well all alts are dwarfs, and they are normal size. I using latest version of script v1.7
It move to every object but dont cast skill.
Re: BlubBlab's Lyliya
Posted: Fri Oct 18, 2013 7:52 am
by BlubBlab
If the bot jump back in a blink of a eye. It doesn't saw the object probable.
If it takes about 1-2 sec the bot tries to cast and can't both ways the reading goes wrong.
You can increase the tries of the bot, but be careful you can use up all your tries this way.
For the first problem I would need reorganize the code, because I must transfer the xyz coordinates to the function(that is planed anyway), at the time the seek the object 3 times until it cast on it.
You can also print some debug info in the loop somewhere here:
Code: Select all
repeat
if(newOne(targetObject.Id)== false)then
i = i + 1;
end
if( i >= 3)then
break;
end
if( z >= 5)then
break;
end
z = z + 1;
until not player:findNearestNameOrId(targetObject.Id)
Re: BlubBlab's Lyliya
Posted: Fri Oct 18, 2013 1:48 pm
by wilifox
Hi, good job!
BlubBlab's i have this error, why? ty
Re: BlubBlab's Lyliya
Posted: Fri Oct 18, 2013 1:53 pm
by BlubBlab
update your rom bot^^
Re: BlubBlab's Lyliya
Posted: Fri Oct 18, 2013 2:47 pm
by wilifox
ok ty , i try tomorrow
Re: BlubBlab's Lyliya
Posted: Mon Oct 21, 2013 3:06 am
by lolita
i added print messages here like you said
Code: Select all
repeat
if(newOne(targetObject.Id)== false)then
i = i + 1;
print("test 1, try #"..i)
end
if( i >= 3)then
print("test 2, try #"..i)
break;
end
if( z >= 5)then
print("test 3, try #"..z)
break;
end
z = z + 1;
until not player:findNearestNameOrId(targetObject.Id)
and when it successfully teleport to object it print
Code: Select all
test 1, try #2
test 1, try #3
test 2, try #3
if it fail to teleport it print
but when it faild to cast skill it print
Code: Select all
test 1, try #2
test 1, try #3
test 2, try #3
so it go to every object, but never use skill
Re: BlubBlab's Lyliya
Posted: Mon Oct 21, 2013 3:52 am
by runegod
nice job on this for new mini game
i also have some problem with this bot though,
most or actually all of the times, when there are 5 objects to be detected in the game, the bot takes a very long time to move to every single item, especially when there are items in the upper floor, the teleportation moves very slow or should i say short distance.
do we have to change any kind of skill range on our own character profiles to make the bot work better?
well bot works good, but not 100% to be able to complete every single round, but does good enough to last all 9 rounds and recieve 45 shells from the game, which i really care and only want,
good job.
Re: BlubBlab's Lyliya
Posted: Thu Nov 07, 2013 11:23 pm
by BlubBlab
I updated the script. It will now take in account the buy options, and press the right button to go in if they appear.
Re: BlubBlab's Lyliya
Posted: Fri Nov 08, 2013 1:15 am
by rido_knight
BlubBlab wrote:I updated the script. It will now take in account the buy options, and press the right button to go in if they appear.
Thanks for update ^_^ will you make Malatina's servant minigame script?
