minor bug: returning to waypoints without return waypoints

[d003232]

The bot tries to return to waypoints (means waypoint #0 (0, 0) ) after death even if there is no returning waypoint list defined. It is at bot.lua line 216:

Code: Select all

			-- Must have a resurrect macro and waypoints set to be able to use
			-- a return path!
	        printf("DEBUG: **************> RES_MACRO %s player.Returning %s __RPL %s\n", settings.profile.hotkeys.RES_MACRO, player.Returning, __RPL); 	-- STEPH01
			if( settings.profile.hotkeys.RES_MACRO and player.Returning == false and
			__RPL ~= nil ) then
				player.Returning = true;
				__RPL:setWaypointIndex(1); -- Start from the beginning
			else
				pauseOnDeath();
			end

For the values of the variables see the attached screenshot. I'm wondering if there is a reason for not check the return path 'settings.profile.options.RETURNPATH' in the profile for 'nil' instead of all that other variables?

[Administrator]

Another good find. It has been fixed and committed to SVN.

[3cmSailorfuku]

The bot tries to return to waypoints (means waypoint #0 (0, 0) ) after death even if there is no returning waypoint list defined. It is at bot.lua line 216:

Code: Select all

			-- Must have a resurrect macro and waypoints set to be able to use
			-- a return path!
	        printf("DEBUG: **************> RES_MACRO %s player.Returning %s __RPL %s\n", settings.profile.hotkeys.RES_MACRO, player.Returning, __RPL); 	-- STEPH01
			if( settings.profile.hotkeys.RES_MACRO and player.Returning == false and
			__RPL ~= nil ) then
				player.Returning = true;
				__RPL:setWaypointIndex(1); -- Start from the beginning
			else
				pauseOnDeath();
			end

For the values of the variables see the attached screenshot. I'm wondering if there is a reason for not check the return path 'settings.profile.options.RETURNPATH' in the profile for 'nil' instead of all that other variables?

Same goes for the waypoint path, it's not being check either and will try to walk to 0,0 if its not set.

[Administrator]

Same goes for the waypoint path, it's not being check either and will try to walk to 0,0 if its not set.

What do you mean? Exactly what would cause the situation you are describing? Just dieing when a return path isn't set?

[3cmSailorfuku]

Same goes for the waypoint path, it's not being check either and will try to walk to 0,0 if its not set.

What do you mean? Exactly what would cause the situation you are describing? Just dieing when a return path isn't set?

No. It's the same issue like he mentioned, but it's the waypoint, not the return path.
It doesn't check if it's NIL and simply walks to 0,0 if none is set.

Just try this
<option name="WAYPOINTS" value="" />