Changelog 745 (RC3)

[botje]

just normal botting, no clue how to trigger it yet im afraid...

[rock5]

I think you edited your post so I missed these.

also, RB assist still doesnt detect me being dead.

Shouldn't need to. rbassist is for manual play. You die, you click the button. It shouldn't crash though. And when you resurrect, it should be ready to continue.

follwing error occured, out of nothing basicly, using the assist script.

I should have checked for that. I made that function and other associated functions local to the cast function because that's where it's made for. I forgot that it was used in checkpotions too. The reason I made it local to "cast" is because I didn't want people to think they could use it for anything because there are situations where it wouldn't work. I think I'll leave them local to "cast" but recreate player:waitTillCastingEnds() and make it a general purpose function that can be used for anything. It will just basically wait till the casting ends minus the undercut, nothing fancy.

[botje]

yes, i didnt want to spam to much double posts xd

i know its for manual play, but it keeps trying to cast heals and use potions till i revive myself, that cant be the way it should work?

it should say, we died, sorry and go in pause right?

edit, whats this?

Code: Select all

Id 535155 not found
Id 538158 not found

[rock5]

i know its for manual play, but it keeps trying to cast heals and use potions till i revive myself, that cant be the way it should work?

Good point. I'll look into it.

edit, whats this?

Code: Select all

Id 535155 not found
Id 538158 not found

That just means somewhere in the bot it looked those ids up in memory and didn't find them. I sometimes have ids appear like that on one of my scouts when starting the bot. Because they are invalid ids there is no way to know what part of the bot is causing it. I say as long as it's not causing a problem ignore it.

Edit: Actually, I figured out an easy way to trace it. I set that message to error then when it errored I could look in the micromacro log.txt file to see the trace back. Turns out it's when it looks up the name of item stats. Normally for stats it looks up a number in memory then adds 500000 to come to the id. There are obviously some items that have numbers where the stat ids should be but aren't stat ids. So when it adds 500000 it end up with invalid ids. The item I was having issues with was a "8x Purified Fusion Stone" but there are probably others. I should probably look at a fix, not sure what I will do though. In this case just checking if the stat has a name would be enough but it's possible that it could accidentally end up with a real name and give the item a stat that it doesn't have. I could probably limit the stat getting to only items that can have stats. That would probably be the best solution.

[grande]

Not sure if it's related to this version of the bot but this isn't working:

Code: Select all

RoMScript("AcceptBorderQuest()")

I think I'm running the third release.

[botje]

found another one, warrior open flank, still fails to cast, due to rage requirements.

also, could ya perhaps post the quick fix for that error i found? its getting a bit on my nerve...

[rock5]

Not sure if it's related to this version of the bot but this isn't working:

Code: Select all

RoMScript("AcceptBorderQuest()")

I think I'm running the third release.

That wouldn't be caused by any bug in the code. What quest is it failing with? Where did you get the quest?

[rock5]

found another one, warrior open flank, still fails to cast, due to rage requirements.

also, could ya perhaps post the quick fix for that error i found? its getting a bit on my nerve...

You are right about rising tide. I fixed it by finally removing the last of the added undercut. Now it just undercuts by the ping value. You can do it by changing this line about 1362 of functions.lua

Code: Select all

		prior = getPing() + 80

to

Code: Select all

		prior = getPing()

Does open flank require the mob to be vulnerable? maybe the requirement you are seeing is the vulnerable status taking too long. That skill should have a reqbuff added. Try

Code: Select all

	<skill name="WARRIOR_OPEN_FLANK" id="491136" range="50" type="damage" buffname="501503" target="enemy" reqbuffname="501502" reqbufftarget="target" />

Don't be surprised if it casts Probing Attack twice before casting Open Flank. Maybe you could put another skill between the 2.

This is not how I'm going to do it but a quick fix to your error is add this to player.lua.

Code: Select all

CPlayer:waitTillCastingEnds()
    self:updateCasting()
    while self.Casting do
        yrest(50)
        self:updateCasting()
    end
end

[rock5]

I think I've figured out the cooldowns in memory after all. I'm looking to see if I can incorporate it now.

[romaniac]

Retrying to locate the NPC does not work
Restarting the bot does not work....

That is a lot of useful information. Thanks. So a simple repeat loop isn't a solution. I suspect some glitch that causes it to stop part way through the list of objects in memory. So the npc you are trying to target is in the part of the list it isn't checking.

I have something else for you to try the next time it happens. Try going out of range of the npc until it's not visible then going back to it and try again. That should move the objects in memory around and maybe the npc will work again.

I tried to do that, but when I moved away the client crashed. So yes, I guess it was getting confused and ready for a crit.

Anyway, before that I ran DumpObjects() and you're right the npc is not on the list. This is what it gave me, standing right in front of Cedric on Varanas square:

Code: Select all

Name:  ID: 0, distance 5676
Name:  ID: 0, distance 5676
Name:  ID: 0, distance 5676
Name:  ID: 0, distance 5676
Name:  ID: 0, distance 5676
Name:  ID: 0, distance 5676
Name: ÞþÉ ID: 1000, distance 450
Name: ÞþÉ ID: 113199, distance 28
Name: Runiger ID: 1000, distance 84
Name: ÞþÉ ID: 111378, distance 5079
Name: ÞþÉ ID: 111378, distance 5168
Name: ÞþÉ ID: 111378, distance 5257
Name: ÞþÉ ID: 111378, distance 5082
Name: ÞþÉ ID: 111378, distance 5168
Name:  ID: 0, distance 5676
Name: ÞþÉ ID: 111717, distance 395
Name: ÞþÉ ID: 111708, distance 387
Name: ÞþÉ ID: 111707, distance 401
Name: ÞþÉ ID: 111698, distance 386
Name: ÞþÉ ID: 111698, distance 389
Name: ÞþÉ ID: 111697, distance 391
Name: ÞþÉ ID: 111687, distance 411
Name: Katharine Fulei ID: 113587, distance 446
Name: ÞþÉ ID: 100044, distance 484
Name: ÞþÉ ID: 100044, distance 497
Name: ÞþÉ ID: 113116, distance 436
Name: ÞþÉ ID: 111813, distance 436
Name: ÞþÉ ID: 117554, distance 425
Name: ÞþÉ ID: 120338, distance 422
Name: ÞþÉ ID: 119763, distance 576
Name: ÞþÉ ID: 119533, distance 574
Name: ÞþÉ ID: 118185, distance 570
Name: ÞþÉ ID: 100564, distance 2501
Name: ÞþÉ ID: 100564, distance 2590
Name: ÞþÉ ID: 100564, distance 2929
Name: ÞþÉ ID: 100564, distance 3002
Name: ÞþÉ ID: 100564, distance 2933
Name: ÞþÉ ID: 100564, distance 3008
Name: ÞþÉ ID: 100564, distance 2590
Name: ÞþÉ ID: 100564, distance 2505
Name: ÞþÉ ID: 100292, distance 5120
Name: ÞþÉ ID: 100286, distance 5537
Name: Zu Maidges Hof ID: 100286, distance 5537
Name: Zu Maidges Hof ID: 100286, distance 6536
Name: ÞþÉ ID: 100286, distance 7266
Name: Nach Varanas ID: 100286, distance 5363
Name: Zu Dorians Hof ID: 100286, distance 7787
Name: ÞþÉ ID: 100286, distance 7787
Name: ÞþÉ ID: 100286, distance 11481
Name: Nach Varanas ID: 100286, distance 11481
Name: Zum Aslan-Tal ID: 100286, distance 11481
Name: Zu Peers Hof ID: 100286, distance 4741
Name: ÞþÉ ID: 100286, distance 4742
Name: Zu Peers Hof ID: 100286, distance 4544
Name: ÞþÉ ID: 110707, distance 1946
Name: ÞþÉ ID: 110477, distance 8081
Name: ÞþÉ ID: 110190, distance 10864
Name: ÞþÉ ID: 110189, distance 10492
Name: ÞþÉ ID: 110188, distance 11966
Name: ÞþÉ ID: 110187, distance 11375
Name: ÞþÉ ID: 113569, distance 1836
Name: ÞþÉ ID: 100044, distance 301
Name: ÞþÉ ID: 111678, distance 420
Name: ÞþÉ ID: 113017, distance 385
Name: ÞþÉ ID: 113016, distance 378
Name: D'monk Jarfur ID: 113015, distance 350
Name: Kalani Jackel ID: 113611, distance 306
Name: Penny Shackley ID: 113613, distance 320
Name: Xenon Kaijala ID: 113612, distance 311
Name: ÞþÉ ID: 113463, distance 318
Name: ÞþÉ ID: 113036, distance 321
Name: ÞþÉ ID: 111728, distance 327
Name: ÞþÉ ID: 111698, distance 327
Name: ÞþÉ ID: 111698, distance 322
Name: ÞþÉ ID: 111698, distance 317
Name: ÞþÉ ID: 111698, distance 394
Name: ÞþÉ ID: 113462, distance 393
Name: ÞþÉ ID: 111687, distance 440
Name: ÞþÉ ID: 111687, distance 428
Name: ÞþÉ ID: 111678, distance 483
Name: ÞþÉ ID: 100044, distance 489
Name: ÞþÉ ID: 113964, distance 474
Name: Zuckerrohrsaft ID: 121153, distance 474
Name: ÞþÉ ID: 121167, distance 467
Name: ÞþÉ ID: 113962, distance 461
Name: ÞþÉ ID: 113961, distance 432
Name: Auktionshaus ID: 110685, distance 398
Name: ÞþÉ ID: 113980, distance 467
Name: ÞþÉ ID: 120336, distance 460
Name: ÞþÉ ID: 120340, distance 452
Name: Limettensaft ID: 120343, distance 459
Name: ÞþÉ ID: 121166, distance 451
Name: ÞþÉ ID: 110575, distance 324
Name: ÞþÉ ID: 110570, distance 311
Name: ÞþÉ ID: 113610, distance 402
Name: Yalon Bollman ID: 113609, distance 402
Name: Macie Weigley ID: 113608, distance 397
Name: ÞþÉ ID: 1000, distance 0
Name: ÞþÉ ID: 110580, distance 444
Name: ÞþÉ ID: 110580, distance 433
Name: ÞþÉ ID: 100946, distance 430
Name: ÞþÉ ID: 110580, distance 460
Name: ÞþÉ ID: 100946, distance 444
Name: ÞþÉ ID: 110049, distance 408
Name: ÞþÉ ID: 114121, distance 123
Name: ÞþÉ ID: 115816, distance 20
Name: ÞþÉ ID: 115815, distance 20
Name: ÞþÉ ID: 1000, distance 10
Name: ÞþÉ ID: 114305, distance 115
Name: ÞþÉ ID: 114087, distance 88
Name: Noab Lucerne ID: 113013, distance 379
Name: ÞþÉ ID: 110986, distance 78
Name: ÞþÉ ID: 110538, distance 80
Name: ÞþÉ ID: 111678, distance 331
Name: ÞþÉ ID: 100044, distance 355
Name: ÞþÉ ID: 100044, distance 323
Name: ÞþÉ ID: 1003, distance 178
Name: <UNKNOWN> ID: 100714, distance 84
Name: <UNKNOWN> ID: 100714, distance 84

[rock5]

If the game is in the process of crashing then there is nothing to do. And Cedric was in the list

Code: Select all

Name: ÞþÉ ID: 115815, distance 20

Although the name's messed up.

I guess your issue is different than what happened to me that one time. As I was able to complete the quest manually and continue the script.

[romaniac]

The other times the game did not crash and I could continue manually.

Does the messed up name explain that the NPC could not be found or is it determined in another way?

[rock5]

Looking at the code I'd say if you search by name it searches by name, if you search by id then it searches by id. I'm assuming then that you searched by name.

[nightclaw]

ok tryed my new beta on ks runs today and i keep geting this error every so offten ....and then it just stops it well take few runs befor it does it



on my norm rom bot this works fine for days but on beta i get this alot now

[rock5]

Yeah sorry about that. I have big plans for getting cooldown and maybe casttime from memory but I think I need to release a quick fix for this error.

[botje]

warrior agressiveness and shout fail to cast.

[rock5]

Does it actually fail to cast or does it just say that it failed to cast? Also, are they able to cast? Do you see any red/orange messages appear on screen when they fail to cast? What skill do they follow? A copy of a typical attack printout would be useful.

Also do you see anything wrong with the skill settup?

Code: Select all

	<skill name="WARRIOR_SHOUT" id="490136" range="90" cooldown="120" type="damage" target="enemy" aoecenter="player" />
	<skill name="WARRIOR_AGGRESSIVENESS" id="490123" cooldown="180" type="buff" target="self" />

What I can tell is the cooldowns are correct and I can tell from memory that they both trigger the global cooldown. I notice that Aggressiveness is a buff but is missing 'buffname'. It might be 500107 but to be sure, ebter the following in the game when you have the buff,

Code: Select all

/script i=1 while UnitBuff( "player", i) ~= nil do name, __, __, ID = UnitBuff( "player", i) SendSystemChat(name.." "..ID) i = i + 1 end

[botje]

they dont look wrong to me, except that it needs rage to execute.

ill post the fight log when i can get ingame again, proberly maintenance now.

[rock5]

Rage and other power requirements are gotten from memory now.

[botje]

Code: Select all

[DEBUG] 0 target HP is less than 1
Engaging enemy [Ankes Agent] in combat.
Use MACRO: WARRIOR_TERROR      =>   * Failed to cast *
Use MACRO: WARRIOR_SLASH       =>   Ankes Agent (111112/11
Use MACRO: WARRIOR_SLASH       =>   * Failed to cast *
Use MACRO: WARRIOR_TERROR      =>   * Failed to cast *
Use MACRO: WARRIOR_TACTICAL_ATT=>   * Failed to cast *
Use MACRO: WARRIOR_TERROR      =>   * Failed to cast *
Use MACRO: WARRIOR_PROBING_ATTA=>   * Failed to cast *
MACRO: Using HP potion 20740/44408 (46%): Herb of Hope (qt
Use MACRO: WARRIOR_TERROR      =>   * Failed to cast *
Use MACRO: WARRIOR_OPEN_FLANK  =>   * Failed to cast *
Taking too long to damage target, breaking sequence...
Clearing target.
Current fight aborted.
Clearing target.
Engaging enemy [Ankes Agent] in combat.
Use MACRO: WARRIOR_TERROR      =>   * Failed to cast *
Use MACRO: WARRIOR_SLASH       =>   * Failed to cast *
Use MACRO: WARRIOR_TERROR      =>   * Failed to cast *
Use MACRO: WARRIOR_BLASTING_CYC=>   Ankes Agent (0/116821)

Code: Select all

Use MACRO: WARRIOR_SHOUT        undercut GCD by 0.9=>   * Failed
Taking too long to damage target, breaking sequence...
Clearing target.
Current fight aborted.
Use MACRO: WARRIOR_FRENZY      =>   * Failed to cast *
Use MACRO: WARRIOR_FRENZY      =>   * Failed to cast *
Use MACRO: WARRIOR_FRENZY      =>   * Failed to cast *
Use MACRO: WARRIOR_FRENZY      =>   * Failed to cast *
Use MACRO: WARRIOR_FRENZY      =>   * Failed to cast *
Use MACRO: WARRIOR_FRENZY      =>   * Failed to cast *
Engaging enemy [Ankes Healer] in combat.
Moving in | Suggested range: 50 | Distance: 59
Use MACRO: WARRIOR_FRENZY      =>   * Failed to cast *
Use MACRO: WARRIOR_FRENZY      =>   * Failed to cast *
Use MACRO: WARRIOR_SLASH       =>   Ankes Healer (33664/119912)

now it does'nt use them xd

finally, got them

Code: Select all

Use MACRO: WARRIOR_SLASH       =>   Ankes Agent (99872/116821)
Use MACRO: WARRIOR_SHOUT        undercut GCD by 0.2=>   * Failed to cast *
Use MACRO: WARRIOR_BLASTING_CYC=>   * Failed to cast *
Use MACRO: WARRIOR_AGGRESSIVENE=>   * Failed to cast *
Use MACRO: WARRIOR_SHOUT       =>   * Failed to cast *
Use MACRO: WARRIOR_AGGRESSIVENE=>   * Failed to cast *
Use MACRO: WARRIOR_SHOUT       =>   * Failed to cast *
Use MACRO: WARRIOR_SLASH       =>   Ankes Agent (51305/116821)
Use MACRO: WARRIOR_SHOUT        undercut GCD by 0.1=>   * Failed to cast *
Use MACRO: WARRIOR_TACTICAL_ATT=>   Ankes Agent (48669/116821)
Use MACRO: WARRIOR_SHOUT        undercut GCD by 0.3=>   * Failed to cast *
Use MACRO: WARRIOR_PROBING_ATTA=>   Ankes Agent (29019/116821)

but as you see, i still have lots of failed casts.

edit, ID is indeed 500107